From issues-return-3749-archive-asf-public=cust-asf.ponee.io@phoenix.apache.org  Thu Jan  3 22:56:56 2019
Return-Path: <issues-return-3749-archive-asf-public=cust-asf.ponee.io@phoenix.apache.org>
X-Original-To: archive-asf-public@cust-asf.ponee.io
Delivered-To: archive-asf-public@cust-asf.ponee.io
Received: from mail.apache.org (hermes.apache.org [140.211.11.3])
	by mx-eu-01.ponee.io (Postfix) with SMTP id 011CD180608
	for <archive-asf-public@cust-asf.ponee.io>; Thu,  3 Jan 2019 22:56:55 +0100 (CET)
Received: (qmail 29362 invoked by uid 500); 3 Jan 2019 21:56:55 -0000
Mailing-List: contact issues-help@phoenix.apache.org; run by ezmlm
Precedence: bulk
List-Help: <mailto:issues-help@phoenix.apache.org>
List-Unsubscribe: <mailto:issues-unsubscribe@phoenix.apache.org>
List-Post: <mailto:issues@phoenix.apache.org>
List-Id: <issues.phoenix.apache.org>
Reply-To: dev@phoenix.apache.org
Delivered-To: mailing list issues@phoenix.apache.org
Received: (qmail 29352 invoked by uid 99); 3 Jan 2019 21:56:55 -0000
Received: from git1-us-west.apache.org (HELO git1-us-west.apache.org) (140.211.11.23)
    by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 03 Jan 2019 21:56:55 +0000
Received: by git1-us-west.apache.org (ASF Mail Server at git1-us-west.apache.org, from userid 33)
	id C453AE1198; Thu,  3 Jan 2019 21:56:54 +0000 (UTC)
From: twdsilva <git@git.apache.org>
To: issues@phoenix.apache.org
Reply-To: issues@phoenix.apache.org
References: <git-pr-424-phoenix@git.apache.org>
In-Reply-To: <git-pr-424-phoenix@git.apache.org>
Subject: [GitHub] phoenix pull request #424: PHOENIX-4820
Content-Type: text/plain
Message-Id: <20190103215654.C453AE1198@git1-us-west.apache.org>
Date: Thu,  3 Jan 2019 21:56:54 +0000 (UTC)

Github user twdsilva commented on a diff in the pull request:

    https://github.com/apache/phoenix/pull/424#discussion_r245145423
  
    --- Diff: phoenix-core/src/main/java/org/apache/phoenix/expression/BaseExpression.java ---
    @@ -255,4 +255,15 @@ public boolean requiresFinalEvaluation() {
             return false;
         }
     
    +    @Override
    +    public boolean isCloneExpression()  {
    +       return isCloneExpressionByDeterminism(this);
    +    }
    +
    +    protected static boolean isCloneExpressionByDeterminism(BaseExpression expression) {
    --- End diff --
    
    nit: I don't think this method is need, you can just inline this in ```public boolean isCloneExpression() ```


---