From issues-return-4285-archive-asf-public=cust-asf.ponee.io@phoenix.apache.org Wed Jan 30 00:07:36 2019 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx-eu-01.ponee.io (Postfix) with SMTP id D6D2D18067E for ; Wed, 30 Jan 2019 01:07:35 +0100 (CET) Received: (qmail 49998 invoked by uid 500); 30 Jan 2019 00:07:35 -0000 Mailing-List: contact issues-help@phoenix.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@phoenix.apache.org Delivered-To: mailing list issues@phoenix.apache.org Received: (qmail 49988 invoked by uid 99); 30 Jan 2019 00:07:34 -0000 Received: from ec2-52-202-80-70.compute-1.amazonaws.com (HELO gitbox.apache.org) (52.202.80.70) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 30 Jan 2019 00:07:34 +0000 From: GitBox To: issues@phoenix.apache.org Subject: =?utf-8?q?=5BGitHub=5D_karanmehta93_commented_on_a_change_in_pull_request?= =?utf-8?q?_=23433=3A_PHOENIX-4009_Run_UPDATE_STATISTICS_command_by_using_?= =?utf-8?q?MR_integration_on=E2=80=A6?= Message-ID: <154880685439.5795.12682723194819143268.gitbox@gitbox.apache.org> Date: Wed, 30 Jan 2019 00:07:34 -0000 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit karanmehta93 commented on a change in pull request #433: PHOENIX-4009 Run UPDATE STATISTICS command by using MR integration on… URL: https://github.com/apache/phoenix/pull/433#discussion_r252070592 ########## File path: phoenix-core/src/it/java/org/apache/phoenix/schema/stats/NoOpStatsCollectorIT.java ########## @@ -0,0 +1,138 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +package org.apache.phoenix.schema.stats; + +import com.google.common.base.Throwables; +import com.google.common.collect.Iterables; +import org.apache.commons.logging.Log; +import org.apache.commons.logging.LogFactory; +import org.apache.hadoop.hbase.security.AccessDeniedException; +import org.apache.phoenix.end2end.ParallelStatsDisabledIT; +import org.apache.phoenix.util.PropertiesUtil; +import org.apache.phoenix.util.SchemaUtil; +import org.apache.phoenix.util.TestUtil; +import org.junit.Assert; +import org.junit.Before; +import org.junit.Test; + +import java.sql.Array; +import java.sql.Connection; +import java.sql.DriverManager; +import java.sql.PreparedStatement; +import java.sql.ResultSet; +import java.sql.SQLException; +import java.sql.Statement; +import java.util.Properties; + +import static org.apache.phoenix.util.TestUtil.TEST_PROPERTIES; + +/** + * Tests the behavior of stats collection code when stats are disabled on server side + */ +public class NoOpStatsCollectorIT extends ParallelStatsDisabledIT { Review comment: The property was deprecated more than 2 releases ago. As of now I have removed its total usage. I don't think that it would break anything. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: users@infra.apache.org With regards, Apache Git Services