From issues-return-4274-archive-asf-public=cust-asf.ponee.io@phoenix.apache.org Tue Jan 29 08:45:52 2019 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx-eu-01.ponee.io (Postfix) with SMTP id 263DD18067B for ; Tue, 29 Jan 2019 08:45:51 +0100 (CET) Received: (qmail 57596 invoked by uid 500); 29 Jan 2019 07:45:51 -0000 Mailing-List: contact issues-help@phoenix.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@phoenix.apache.org Delivered-To: mailing list issues@phoenix.apache.org Received: (qmail 57577 invoked by uid 99); 29 Jan 2019 07:45:51 -0000 Received: from ec2-52-202-80-70.compute-1.amazonaws.com (HELO gitbox.apache.org) (52.202.80.70) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 29 Jan 2019 07:45:51 +0000 From: GitBox To: issues@phoenix.apache.org Subject: [GitHub] ChinmaySKulkarni commented on a change in pull request #428: PHOENIX-374: Enable access to dynamic columns in * or cf.* selection Message-ID: <154874795065.16884.705039926907376673.gitbox@gitbox.apache.org> Date: Tue, 29 Jan 2019 07:45:50 -0000 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit ChinmaySKulkarni commented on a change in pull request #428: PHOENIX-374: Enable access to dynamic columns in * or cf.* selection URL: https://github.com/apache/phoenix/pull/428#discussion_r251720767 ########## File path: phoenix-core/src/main/java/org/apache/phoenix/compile/ProjectionCompiler.java ########## @@ -501,7 +516,9 @@ public static RowProjector compile(StatementContext context, SelectStatement sta // Ignore as this can happen for local indexes when the data table has a column family, but there are no covered columns in the family } } - return new RowProjector(projectedColumns, Math.max(estimatedKeySize, estimatedByteSize), isProjectEmptyKeyValue, resolver.hasUDFs(), isWildcard); + return new RowProjector(projectedColumns, Math.max(estimatedKeySize, estimatedByteSize), + isProjectEmptyKeyValue, resolver.hasUDFs(), isWildcard, + isWildcard || !projectedFamilies.isEmpty()); Review comment: This should actually be the `wildcardIncludesDynamicCols` check. Will change it. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: users@infra.apache.org With regards, Apache Git Services