From issues-return-4150-archive-asf-public=cust-asf.ponee.io@phoenix.apache.org Wed Jan 23 03:36:28 2019 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx-eu-01.ponee.io (Postfix) with SMTP id BA97D18077A for ; Wed, 23 Jan 2019 03:36:27 +0100 (CET) Received: (qmail 98354 invoked by uid 500); 23 Jan 2019 02:36:26 -0000 Mailing-List: contact issues-help@phoenix.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@phoenix.apache.org Delivered-To: mailing list issues@phoenix.apache.org Received: (qmail 98345 invoked by uid 99); 23 Jan 2019 02:36:26 -0000 Received: from ec2-52-202-80-70.compute-1.amazonaws.com (HELO gitbox.apache.org) (52.202.80.70) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 23 Jan 2019 02:36:26 +0000 From: GitBox To: issues@phoenix.apache.org Subject: [GitHub] comnetwork commented on a change in pull request #431: PHOENIX-5105 Message-ID: <154821098638.2604.7194691746474628334.gitbox@gitbox.apache.org> Date: Wed, 23 Jan 2019 02:36:26 -0000 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit comnetwork commented on a change in pull request #431: PHOENIX-5105 URL: https://github.com/apache/phoenix/pull/431#discussion_r250037949 ########## File path: phoenix-core/src/it/java/org/apache/phoenix/end2end/SortMergeJoinMoreIT.java ########## @@ -742,4 +742,112 @@ private static void verifyQueryPlanAndResultForBug4508( assertFalse(rs.next()); } } + + @Test + public void testSortMergeJoinPushFilterThroughSortBug5105() throws Exception { + Connection conn = null; + try { + Properties props = PropertiesUtil.deepCopy(TEST_PROPERTIES); + conn = DriverManager.getConnection(getUrl(), props); + + String tableName1=generateUniqueName(); + String tableName2=generateUniqueName(); + + conn.createStatement().execute("DROP TABLE if exists "+tableName1); Review comment: Yes, I would omit it. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: users@infra.apache.org With regards, Apache Git Services