From issues-return-3984-archive-asf-public=cust-asf.ponee.io@phoenix.apache.org Fri Jan 11 19:59:29 2019 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx-eu-01.ponee.io (Postfix) with SMTP id 14D9F180676 for ; Fri, 11 Jan 2019 19:59:28 +0100 (CET) Received: (qmail 46156 invoked by uid 500); 11 Jan 2019 18:59:28 -0000 Mailing-List: contact issues-help@phoenix.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@phoenix.apache.org Delivered-To: mailing list issues@phoenix.apache.org Received: (qmail 46147 invoked by uid 99); 11 Jan 2019 18:59:28 -0000 Received: from ec2-52-202-80-70.compute-1.amazonaws.com (HELO gitbox.apache.org) (52.202.80.70) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 11 Jan 2019 18:59:28 +0000 From: GitBox To: issues@phoenix.apache.org Subject: =?utf-8?q?=5BGitHub=5D_karanmehta93_commented_on_a_change_in_pull_request?= =?utf-8?q?_=23419=3A_PHOENIX-4009_Run_UPDATE_STATISTICS_command_by_using_?= =?utf-8?q?MR_integration_on=E2=80=A6?= Message-ID: <154723316772.24872.5838344701344130243.gitbox@gitbox.apache.org> Date: Fri, 11 Jan 2019 18:59:27 -0000 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit karanmehta93 commented on a change in pull request #419: PHOENIX-4009 Run UPDATE STATISTICS command by using MR integration on… URL: https://github.com/apache/phoenix/pull/419#discussion_r247220684 ########## File path: phoenix-core/src/main/java/org/apache/phoenix/mapreduce/util/PhoenixConfigurationUtil.java ########## @@ -154,7 +154,8 @@ public enum SchemaType { TABLE, - QUERY; + QUERY, + UPDATE_STATS Review comment: @BinShi-SecularBird Although its _primarily_ being used for phoenix-pig module, phoenix-core also uses it to determine the query it needs to run for MR job. I want to _extend_ the meaning of `SchemaType` enum to suggest this as well since that can be extended again if we have new types/use cases in future. Adding a configuration each time doesn't seem good to me. @dbwong? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: users@infra.apache.org With regards, Apache Git Services