From issues-return-3983-archive-asf-public=cust-asf.ponee.io@phoenix.apache.org Fri Jan 11 19:52:10 2019 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx-eu-01.ponee.io (Postfix) with SMTP id 12FFD180676 for ; Fri, 11 Jan 2019 19:52:09 +0100 (CET) Received: (qmail 20448 invoked by uid 500); 11 Jan 2019 18:52:09 -0000 Mailing-List: contact issues-help@phoenix.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@phoenix.apache.org Delivered-To: mailing list issues@phoenix.apache.org Received: (qmail 20439 invoked by uid 99); 11 Jan 2019 18:52:09 -0000 Received: from ec2-52-202-80-70.compute-1.amazonaws.com (HELO gitbox.apache.org) (52.202.80.70) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 11 Jan 2019 18:52:09 +0000 From: GitBox To: issues@phoenix.apache.org Subject: =?utf-8?q?=5BGitHub=5D_karanmehta93_commented_on_a_change_in_pull_request?= =?utf-8?q?_=23419=3A_PHOENIX-4009_Run_UPDATE_STATISTICS_command_by_using_?= =?utf-8?q?MR_integration_on=E2=80=A6?= Message-ID: <154723272867.13069.14600295496364336743.gitbox@gitbox.apache.org> Date: Fri, 11 Jan 2019 18:52:08 -0000 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit karanmehta93 commented on a change in pull request #419: PHOENIX-4009 Run UPDATE STATISTICS command by using MR integration on… URL: https://github.com/apache/phoenix/pull/419#discussion_r247218618 ########## File path: phoenix-pig/src/main/java/org/apache/phoenix/pig/util/PhoenixPigSchemaUtil.java ########## @@ -62,7 +62,7 @@ public static ResourceSchema getResourceSchema(final Configuration configuration Preconditions.checkNotNull(sqlQuery, "No Sql Query exists within the configuration"); final SqlQueryToColumnInfoFunction function = new SqlQueryToColumnInfoFunction(configuration); columns = function.apply(sqlQuery); - } else { + } else if (SchemaType.TABLE.equals(schemaType)) { Review comment: Yes I agree that we should standardize it. There is no pre-defined standard here and both of them work in theory. Any particular prefs you suggest for one over other? Also can you point me to other location (if you remember)? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: users@infra.apache.org With regards, Apache Git Services