From issues-return-3899-archive-asf-public=cust-asf.ponee.io@phoenix.apache.org Wed Jan 9 06:09:24 2019 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx-eu-01.ponee.io (Postfix) with SMTP id E39E9180676 for ; Wed, 9 Jan 2019 06:09:23 +0100 (CET) Received: (qmail 67961 invoked by uid 500); 9 Jan 2019 05:09:23 -0000 Mailing-List: contact issues-help@phoenix.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@phoenix.apache.org Delivered-To: mailing list issues@phoenix.apache.org Received: (qmail 67935 invoked by uid 99); 9 Jan 2019 05:09:22 -0000 Received: from ec2-52-202-80-70.compute-1.amazonaws.com (HELO gitbox.apache.org) (52.202.80.70) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 09 Jan 2019 05:09:22 +0000 From: GitBox To: issues@phoenix.apache.org Subject: =?utf-8?q?=5BGitHub=5D_karanmehta93_commented_on_a_change_in_pull_request?= =?utf-8?q?_=23419=3A_PHOENIX-4009_Run_UPDATE_STATISTICS_command_by_using_?= =?utf-8?q?MR_integration_on=E2=80=A6?= Message-ID: <154701056241.20319.10631425688595938201.gitbox@gitbox.apache.org> Date: Wed, 09 Jan 2019 05:09:22 -0000 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit karanmehta93 commented on a change in pull request #419: PHOENIX-4009 Run UPDATE STATISTICS command by using MR integration on… URL: https://github.com/apache/phoenix/pull/419#discussion_r246261216 ########## File path: phoenix-core/src/main/java/org/apache/phoenix/mapreduce/PhoenixRecordReader.java ########## @@ -108,6 +109,7 @@ public void initialize(InputSplit split, TaskAttemptContext context) throws IOEx final PhoenixInputSplit pSplit = (PhoenixInputSplit)split; final List scans = pSplit.getScans(); try { + LOG.info("Generating iterators for " + scans.size() + " scans in keyrange: " + pSplit.getKeyRange()); Review comment: Record reader is initialized once per mapper job and the map jobs are limited by number of regions. Also these logs will be distributed on several machines and not one. It would be good to have some insight here on the iterators each reader is trying to generate. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: users@infra.apache.org With regards, Apache Git Services