phoenix-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hadoop QA (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (PHOENIX-5112) Simplify QueryPlan selection in Phoenix.
Date Wed, 30 Jan 2019 11:54:00 GMT

    [ https://issues.apache.org/jira/browse/PHOENIX-5112?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16756015#comment-16756015
] 

Hadoop QA commented on PHOENIX-5112:
------------------------------------

{color:red}-1 overall{color}.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12956851/5112-master.txt
  against master branch at commit 77fdcc2845d56fa3b39e5a6bdd4d5d058a5aa977.
  ATTACHMENT ID: 12956851

    {color:green}+1 @author{color}.  The patch does not contain any @author tags.

    {color:red}-1 tests included{color}.  The patch doesn't appear to include any new or modified
tests.
                        Please justify why no new tests are needed for this patch.
                        Also please list what manual steps were performed to verify this patch.

    {color:green}+1 javac{color}.  The applied patch does not increase the total number of
javac compiler warnings.

    {color:red}-1 release audit{color}.  The applied patch generated 1 release audit warnings
(more than the master's current 0 warnings).

    {color:green}+1 lineLengths{color}.  The patch does not introduce lines longer than 100

     {color:red}-1 core tests{color}.  The patch failed these unit tests:
     ./phoenix-core/target/failsafe-reports/TEST-org.apache.phoenix.end2end.UpgradeIT
./phoenix-core/target/failsafe-reports/TEST-org.apache.phoenix.end2end.ConcurrentMutationsIT
./phoenix-core/target/failsafe-reports/TEST-org.apache.phoenix.end2end.DistinctPrefixFilterIT
./phoenix-core/target/failsafe-reports/TEST-org.apache.phoenix.end2end.index.MutableIndexSplitReverseScanIT
./phoenix-core/target/failsafe-reports/TEST-org.apache.phoenix.end2end.index.MutableIndexSplitForwardScanIT

Test results: https://builds.apache.org/job/PreCommit-PHOENIX-Build/2283//testReport/
Release audit warnings: https://builds.apache.org/job/PreCommit-PHOENIX-Build/2283//artifact/patchprocess/patchReleaseAuditWarnings.txt
Console output: https://builds.apache.org/job/PreCommit-PHOENIX-Build/2283//console

This message is automatically generated.

> Simplify QueryPlan selection in Phoenix.
> ----------------------------------------
>
>                 Key: PHOENIX-5112
>                 URL: https://issues.apache.org/jira/browse/PHOENIX-5112
>             Project: Phoenix
>          Issue Type: Improvement
>            Reporter: Lars Hofhansl
>            Priority: Major
>         Attachments: 5112-master.txt
>
>
> Brought to light in part in PHOENIX-5109, plan selection in Phoenix is too complicated
with its logic spread over multiple areas. My recent changes let most index through the initial
filters and next step is to put all the logic in {{QueryOptimizer.orderPlansBestToWorst}}.
> One exception is plans with global indexes for queries with uncovered queries, those
should still be handled in {{addPlan}}.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Mime
View raw message