phoenix-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hadoop QA (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (PHOENIX-5093) Schema and Table with leading underscore '_' cannot be queried though grammar says it is valid.
Date Tue, 15 Jan 2019 03:20:00 GMT

    [ https://issues.apache.org/jira/browse/PHOENIX-5093?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16742704#comment-16742704
] 

Hadoop QA commented on PHOENIX-5093:
------------------------------------

{color:red}-1 overall{color}.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12954893/PHOENIX-5093.patch
  against master branch at commit 3bd426f10337b6e109ab7394bd4a4023039fd0e8.
  ATTACHMENT ID: 12954893

    {color:green}+1 @author{color}.  The patch does not contain any @author tags.

    {color:red}-1 tests included{color}.  The patch doesn't appear to include any new or modified
tests.
                        Please justify why no new tests are needed for this patch.
                        Also please list what manual steps were performed to verify this patch.

    {color:green}+1 javac{color}.  The applied patch does not increase the total number of
javac compiler warnings.

    {color:red}-1 release audit{color}.  The applied patch generated 1 release audit warnings
(more than the master's current 0 warnings).

    {color:red}-1 lineLengths{color}.  The patch introduces the following lines longer than
100:
    +            String createTable = "CREATE TABLE IF NOT EXISTS " + qualifiedName + " (ID
INTEGER NOT NULL PRIMARY KEY, VAL VARCHAR)";
+            String query = "SELECT count(*) from " + "\"" + schemaName + "\"" + "." + "\""
 + tableName + "\"";

     {color:red}-1 core tests{color}.  The patch failed these unit tests:
                       org.apache.phoenix.parse.QueryParserTest
                  org.apache.phoenix.compile.QueryCompilerTest
                  org.apache.phoenix.util.PhoenixRuntimeTest

Test results: https://builds.apache.org/job/PreCommit-PHOENIX-Build/2243//testReport/
Release audit warnings: https://builds.apache.org/job/PreCommit-PHOENIX-Build/2243//artifact/patchprocess/patchReleaseAuditWarnings.txt
Console output: https://builds.apache.org/job/PreCommit-PHOENIX-Build/2243//console

This message is automatically generated.

> Schema and Table with leading underscore '_' cannot be queried though grammar says it
is valid.
> -----------------------------------------------------------------------------------------------
>
>                 Key: PHOENIX-5093
>                 URL: https://issues.apache.org/jira/browse/PHOENIX-5093
>             Project: Phoenix
>          Issue Type: Bug
>    Affects Versions: 4.13.0
>            Reporter: Daniel Wong
>            Assignee: Daniel Wong
>            Priority: Minor
>         Attachments: PHOENIX-5093.patch
>
>          Time Spent: 20m
>  Remaining Estimate: 0h
>
> See below for failing IT written by me.  Encountered locally while debugging issues
on our clusters.  Should work according to grammar here: https://phoenix.apache.org/language/index.html#name
> May be a good newbie case.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Mime
View raw message