phoenix-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hadoop QA (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (PHOENIX-5080) Index becomes Active during Partial Index Rebuilder if Index Failure happens
Date Wed, 23 Jan 2019 08:33:00 GMT

    [ https://issues.apache.org/jira/browse/PHOENIX-5080?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16749657#comment-16749657
] 

Hadoop QA commented on PHOENIX-5080:
------------------------------------

{color:red}-1 overall{color}.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12955897/PHOENIX-5080-4.x-HBase-1.3.02.patch
  against 4.x-HBase-1.3 branch at commit c8686ce73093b879bbda5f08f3e7933a9708e110.
  ATTACHMENT ID: 12955897

    {color:green}+1 @author{color}.  The patch does not contain any @author tags.

    {color:red}-1 tests included{color}.  The patch doesn't appear to include any new or modified
tests.
                        Please justify why no new tests are needed for this patch.
                        Also please list what manual steps were performed to verify this patch.

    {color:green}+1 javac{color}.  The applied patch does not increase the total number of
javac compiler warnings.

    {color:red}-1 release audit{color}.  The applied patch generated 1 release audit warnings
(more than the master's current 0 warnings).

    {color:red}-1 lineLengths{color}.  The patch introduces the following lines longer than
100:
    +              if (replayWrite == ReplayWrite.INDEX_ONLY || replayWrite == ReplayWrite.REBUILD_INDEX_ONLY)
{
+        return attributes.get(BaseScannerRegionObserver.REPLAY_WRITES) == BaseScannerRegionObserver.REPLAY_INDEX_REBUILD_WRITES;

    {color:green}+1 core tests{color}.  The patch passed unit tests in .

Test results: https://builds.apache.org/job/PreCommit-PHOENIX-Build/2268//testReport/
Release audit warnings: https://builds.apache.org/job/PreCommit-PHOENIX-Build/2268//artifact/patchprocess/patchReleaseAuditWarnings.txt
Console output: https://builds.apache.org/job/PreCommit-PHOENIX-Build/2268//console

This message is automatically generated.

> Index becomes Active during Partial Index Rebuilder if Index Failure happens
> ----------------------------------------------------------------------------
>
>                 Key: PHOENIX-5080
>                 URL: https://issues.apache.org/jira/browse/PHOENIX-5080
>             Project: Phoenix
>          Issue Type: Bug
>    Affects Versions: 4.14.1
>            Reporter: Monani Mihir
>            Assignee: Monani Mihir
>            Priority: Blocker
>         Attachments: PHOENIX-5080-4.x-HBase-1.3.01.patch, PHOENIX-5080-4.x-HBase-1.3.02.patch,
PHOENIX-5080-4.x-HBase-1.3.02.patch
>
>
> After PHOENIX-4130 and PHOENIX-4600 , If there is Index failure during Partial Index
Rebuild, Rebuilder will try again to write Index updates. If it succeeds then it will transition
Index from INACTIVE to ACTIVE, even before Rebuilder finishes.
> Here is where it goes wrong, I think :- 
> {code:java}
> PhoenixIndexFailurePolicy.java :- 
> public static void doBatchWithRetries(MutateCommand mutateCommand,
>             IndexWriteException iwe, PhoenixConnection connection, ReadOnlyProps
config) throws IOException {
> ....
>     while (canRetryMore(numRetry++, maxTries, canRetryUntil)) {
>     ...
>         handleIndexWriteSuccessFromClient(iwe, connection);
>     ...
>     }
> }
> ....
> private static void handleIndexWriteSuccessFromClient(IndexWriteException indexWriteException,
PhoenixConnection conn) {
>         handleExceptionFromClient(indexWriteException, conn, PIndexState.ACTIVE);
> }
> {code}
>  
>  
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Mime
View raw message