phoenix-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hadoop QA (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (PHOENIX-5059) Use the Datasource v2 api in the spark connector
Date Tue, 08 Jan 2019 01:41:00 GMT

    [ https://issues.apache.org/jira/browse/PHOENIX-5059?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16736568#comment-16736568
] 

Hadoop QA commented on PHOENIX-5059:
------------------------------------

{color:red}-1 overall{color}.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12954059/PHOENIX-5059-4.x-HBase-1.3.patch
  against 4.x-HBase-1.3 branch at commit 52a89f05f5e8a131fdf3ac990d7cfe29cc204711.
  ATTACHMENT ID: 12954059

    {color:green}+1 @author{color}.  The patch does not contain any @author tags.

    {color:green}+1 tests included{color}.  The patch appears to include 2 new or modified
tests.

    {color:red}-1 javac{color}.  The applied patch generated 407 javac compiler warnings (more
than the master's current 401 warnings).

    {color:red}-1 release audit{color}.  The applied patch generated 1 release audit warnings
(more than the master's current 0 warnings).

    {color:red}-1 lineLengths{color}.  The patch introduces the following lines longer than
100:
    +                .setWhereClause("A_INTEGER = 1 AND A_STRING >= 'ab' AND A_STRING <
'de' AND A_ID = '123'");
+            queryBuilder.setWhereClause("A_INTEGER in (2, 4) AND A_STRING = 'abc' AND A_ID
= '123'");
+        PhoenixDataSource.ZOOKEEPER_URL -> quorumAddress, PhoenixDataSource.SKIP_NORMALIZING_IDENTIFIER
-> "true"))
+    val expected = new StructType(List(StructField("varcharColumn", StringType, nullable
= true)).toArray)
+    val expectedResults = Array(Row.fromSeq(Seq(1, "test_row_1")), Row.fromSeq(Seq(2, "test_row_2")))
+    val ddl = "CREATE TABLE SPLIT_TABLE (id VARCHAR NOT NULL PRIMARY KEY, val VARCHAR) split
on ('e','j','o')"
+    val keys = Array("a", "b", "c", "d", "e", "f", "g", "h", "i", "j", "k", "l", "m", "n",
"o", "p", "q", "r", "s",
+      .options( Map("table" -> "SPLIT_TABLE", PhoenixDataSource.ZOOKEEPER_URL -> quorumAddress)).load
+      .options( Map("table" -> SchemaUtil.getEscapedArgument("table4"), PhoenixDataSource.ZOOKEEPER_URL
-> quorumAddress)).load
+      .options( Map("table" -> "TABLE2", PhoenixDataSource.ZOOKEEPER_URL -> quorumAddress)).load.filter("ID
= 1")

     {color:red}-1 core tests{color}.  The patch failed these unit tests:
     ./phoenix-core/target/failsafe-reports/TEST-org.apache.phoenix.end2end.index.MutableIndexFailureWithNamespaceIT
./phoenix-core/target/failsafe-reports/TEST-org.apache.phoenix.end2end.ViewIT

Test results: https://builds.apache.org/job/PreCommit-PHOENIX-Build/2235//testReport/
Release audit warnings: https://builds.apache.org/job/PreCommit-PHOENIX-Build/2235//artifact/patchprocess/patchReleaseAuditWarnings.txt
Console output: https://builds.apache.org/job/PreCommit-PHOENIX-Build/2235//console

This message is automatically generated.

> Use the Datasource v2 api in the spark connector
> ------------------------------------------------
>
>                 Key: PHOENIX-5059
>                 URL: https://issues.apache.org/jira/browse/PHOENIX-5059
>             Project: Phoenix
>          Issue Type: New Feature
>            Reporter: Thomas D'Silva
>            Assignee: Thomas D'Silva
>            Priority: Major
>         Attachments: PHOENIX-5059-4.x-HBase-1.3.patch, PHOENIX-5059.patch
>
>
> Switching to the v2 api will enable pushing downing limits/aggregations and more in the
future.
> https://issues.apache.org/jira/browse/SPARK-15689



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Mime
View raw message