phoenix-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hadoop QA (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (PHOENIX-4009) Run UPDATE STATISTICS command by using MR integration on snapshots
Date Mon, 28 Jan 2019 11:48:00 GMT

    [ https://issues.apache.org/jira/browse/PHOENIX-4009?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16753931#comment-16753931
] 

Hadoop QA commented on PHOENIX-4009:
------------------------------------

{color:red}-1 overall{color}.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12956541/PHOENIX-4009.4.x-HBase-1.4.003.addendum.patch
  against 4.x-HBase-1.4 branch at commit 573ec9f73a86d236a6e69a2bac23f177a29f3c44.
  ATTACHMENT ID: 12956541

    {color:green}+1 @author{color}.  The patch does not contain any @author tags.

    {color:red}-1 tests included{color}.  The patch doesn't appear to include any new or modified
tests.
                        Please justify why no new tests are needed for this patch.
                        Also please list what manual steps were performed to verify this patch.

    {color:green}+1 javac{color}.  The applied patch does not increase the total number of
javac compiler warnings.

    {color:red}-1 release audit{color}.  The applied patch generated 1 release audit warnings
(more than the master's current 0 warnings).

    {color:red}-1 lineLengths{color}.  The patch introduces the following lines longer than
100:
    +                "CREATE TABLE " + fullTableName + " ( k VARCHAR, a_string_array VARCHAR(100)
ARRAY[4],"
+                        + " CONSTRAINT pk PRIMARY KEY (k, b_string_array DESC)) GUIDE_POSTS_WIDTH
= 10");
+        String q1 = "SELECT SUM(GUIDE_POSTS_ROW_COUNT) FROM SYSTEM.STATS WHERE PHYSICAL_NAME
= '" + physicalTableName + "'";
+                        internalScanner = statisticsCollector.createCompactionScanner(compactionConfEnv,
store, internalScanner);
+    STATS_COLLECTION_DISABLED_ON_SERVER(1401, "STS01", "Stats collection attempted but is
disabled on server"),
+		final boolean isStatsEnabled = config.getBoolean(STATS_COLLECTION_ENABLED, DEFAULT_STATS_COLLECTION_ENABLED);
+        return (env.getConfiguration().getBoolean(STATS_COLLECTION_ENABLED, DEFAULT_STATS_COLLECTION_ENABLED))

     {color:red}-1 core tests{color}.  The patch failed these unit tests:
     ./phoenix-core/target/failsafe-reports/TEST-org.apache.phoenix.end2end.QueryWithOffsetIT
./phoenix-core/target/failsafe-reports/TEST-org.apache.phoenix.end2end.SpillableGroupByIT
./phoenix-core/target/failsafe-reports/TEST-org.apache.phoenix.end2end.DistinctPrefixFilterIT
./phoenix-core/target/failsafe-reports/TEST-org.apache.phoenix.end2end.ExplainPlanWithStatsDisabledIT
./phoenix-core/target/failsafe-reports/TEST-org.apache.phoenix.end2end.AggregateIT
./phoenix-core/target/failsafe-reports/TEST-org.apache.phoenix.end2end.UngroupedIT
./phoenix-core/target/failsafe-reports/TEST-org.apache.phoenix.end2end.NullIT
./phoenix-core/target/failsafe-reports/TEST-org.apache.phoenix.end2end.Array1IT
./phoenix-core/target/failsafe-reports/TEST-org.apache.phoenix.end2end.salted.SaltedTableUpsertSelectIT
./phoenix-core/target/failsafe-reports/TEST-org.apache.phoenix.end2end.DateTimeIT
./phoenix-core/target/failsafe-reports/TEST-org.apache.phoenix.end2end.index.MutableIndexFailureIT

Test results: https://builds.apache.org/job/PreCommit-PHOENIX-Build/2275//testReport/
Release audit warnings: https://builds.apache.org/job/PreCommit-PHOENIX-Build/2275//artifact/patchprocess/patchReleaseAuditWarnings.txt
Console output: https://builds.apache.org/job/PreCommit-PHOENIX-Build/2275//console

This message is automatically generated.

> Run UPDATE STATISTICS command by using MR integration on snapshots
> ------------------------------------------------------------------
>
>                 Key: PHOENIX-4009
>                 URL: https://issues.apache.org/jira/browse/PHOENIX-4009
>             Project: Phoenix
>          Issue Type: Bug
>            Reporter: Samarth Jain
>            Assignee: Karan Mehta
>            Priority: Major
>              Labels: stats, statsCollection
>         Attachments: PHOENIX-4009.4.x-HBase-1.4.001.patch, PHOENIX-4009.4.x-HBase-1.4.002.patch,
PHOENIX-4009.4.x-HBase-1.4.003.addendum.patch, PHOENIX-4009.master.001.patch, PHOENIX-4009.master.002.patch,
PHOENIX-4009.master.003.patch
>
>          Time Spent: 13h 20m
>  Remaining Estimate: 0h
>
> Now that we have the capability to run queries against table snapshots through our map
reduce integration, we can utilize this capability for stats collection too. This would make
our stats collection more resilient, resource aware and less resource intensive. The bulk
of the plumbing is already in place. We would need to make sure that the integration doesn't
barf when the query is an UPDATE STATISTICS command.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Mime
View raw message