phoenix-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From jmahonin <...@git.apache.org>
Subject [GitHub] phoenix issue #423: PHOENIX-5059 Use the Datasource v2 api in the spark conn...
Date Mon, 07 Jan 2019 16:08:58 GMT
Github user jmahonin commented on the issue:

    https://github.com/apache/phoenix/pull/423
  
    @twdsilva Very impressive work, well done!
    
    A few questions:
    - Does this break compatibility with previous Spark versions? i.e., Spark 2.3.x wouldn't
be binary-compatible with Phoenix 5.1.x (or whatever the next version ends up being)
    
    - It seems like much of the boiler-plate MR code has been replicated yet-again into this
new integration. The overall structure makes sense here, but I'm wondering if some of that
code shouldn't live in phoenix-spark at all?


---

Mime
View raw message