phoenix-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From karanmehta93 <...@git.apache.org>
Subject [GitHub] phoenix pull request #416: PHOENIX-5069 please go to JIRA to see the detaile...
Date Wed, 02 Jan 2019 21:13:43 GMT
Github user karanmehta93 commented on a diff in the pull request:

    https://github.com/apache/phoenix/pull/416#discussion_r244856169
  
    --- Diff: phoenix-core/src/main/java/org/apache/phoenix/query/GuidePostsCache.java ---
    @@ -80,38 +94,46 @@ public GuidePostsCache(ConnectionQueryServices queryServices, Configuration
conf
                     // Log removals at TRACE for debugging
                     .removalListener(new PhoenixStatsCacheRemovalListener())
                     // Automatically load the cache when entries are missing
    -                .build(new StatsLoader());
    +                .build(new PhoenixStatsCacheLoader(new StatsLoaderImpl(), executor));
         }
     
         /**
    -     * {@link CacheLoader} implementation for the Phoenix Table Stats cache.
    +     * {@link PhoenixStatsLoader} implementation for the Stats Loader.
          */
    -    protected class StatsLoader extends CacheLoader<GuidePostsKey, GuidePostsInfo>
{
    +    protected class StatsLoaderImpl implements PhoenixStatsLoader {
    +        @Override
    +        public boolean needsLoad() {
    +            // Whenever it's called, we try to load stats from stats table
    +            // no matter it has been updated or not.
    +            return true;
    +        }
    +
             @Override
    -        public GuidePostsInfo load(GuidePostsKey statsKey) throws Exception {
    +        public GuidePostsInfo loadStats(GuidePostsKey statsKey, GuidePostsInfo prevGuidepostInfo)
throws Exception {
                 @SuppressWarnings("deprecation")
    -            Table statsHTable = queryServices.getTable(SchemaUtil.getPhysicalName(
    +            TableName tableName = SchemaUtil.getPhysicalName(
                         PhoenixDatabaseMetaData.SYSTEM_STATS_NAME_BYTES,
    -                            queryServices.getProps()).getName());
    +                    queryServices.getProps());
    +            Table statsHTable = queryServices.getTable(tableName.getName());
                 try {
                     GuidePostsInfo guidePostsInfo = StatisticsUtil.readStatistics(statsHTable,
statsKey,
                             HConstants.LATEST_TIMESTAMP);
                     traceStatsUpdate(statsKey, guidePostsInfo);
                     return guidePostsInfo;
                 } catch (TableNotFoundException e) {
                     // On a fresh install, stats might not yet be created, don't warn about
this.
    -                logger.debug("Unable to locate Phoenix stats table", e);
    -                return GuidePostsInfo.NO_GUIDEPOST;
    +                logger.debug("Unable to locate Phoenix stats table: " + tableName.toString(),
e);
    +                return prevGuidepostInfo;
                 } catch (IOException e) {
    -                logger.warn("Unable to read from stats table", e);
    +                logger.warn("Unable to read from stats table: " + tableName.toString(),
e);
                     // Just cache empty stats. We'll try again after some time anyway.
    --- End diff --
    
    nit: remove this comment.


---

Mime
View raw message