phoenix-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] BinShi-SecularBird commented on a change in pull request #430: PHOENIX-5091 Add new features to UpdateStatisticsTool
Date Wed, 30 Jan 2019 01:56:12 GMT
BinShi-SecularBird commented on a change in pull request #430: PHOENIX-5091 Add new features
to UpdateStatisticsTool
URL: https://github.com/apache/phoenix/pull/430#discussion_r252091531
 
 

 ##########
 File path: phoenix-core/src/main/java/org/apache/phoenix/schema/stats/UpdateStatisticsTool.java
 ##########
 @@ -190,9 +252,9 @@ private CommandLine parseOptions(String[] args) {
                     + "parameter");
         }
 
-        if (!cmdLine.hasOption(SNAPSHOT_NAME_OPTION.getOpt())) {
-            throw new IllegalStateException(SNAPSHOT_NAME_OPTION.getLongOpt() + " is a mandatory
"
-                    + "parameter");
+        if (cmdLine.hasOption(MANAGE_SNAPSHOT_OPTION.getOpt())
+                && !cmdLine.hasOption(RUN_FOREGROUND_OPTION.getOpt())) {
+            throw new IllegalStateException("Snapshot cannot be managed if job is running
in background");
 
 Review comment:
   Besides reduce step, the work manager which is responsible for submitting/monitoring/cleaning-up
UPDATE STATISTICS MR jobs should be able to delete the snapshot on which a MR jobs running
in background. IMPO, this is the best place to do it.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message