phoenix-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] BinShi-SecularBird commented on a change in pull request #433: PHOENIX-4009 Run UPDATE STATISTICS command by using MR integration on…
Date Wed, 30 Jan 2019 01:16:42 GMT
BinShi-SecularBird commented on a change in pull request #433: PHOENIX-4009 Run UPDATE STATISTICS
command by using MR integration on…
URL: https://github.com/apache/phoenix/pull/433#discussion_r252084064
 
 

 ##########
 File path: phoenix-core/src/main/java/org/apache/phoenix/exception/SQLExceptionCode.java
 ##########
 @@ -464,6 +464,8 @@ public SQLException newException(SQLExceptionInfo info) {
     INSUFFICIENT_MEMORY(999, "50M01", "Unable to allocate enough memory."),
     HASH_JOIN_CACHE_NOT_FOUND(900, "HJ01", "Hash Join cache not found"),
 
+    STATS_COLLECTION_DISABLED_ON_SERVER(1401, "STS01", "Stats collection attempted but is
disabled on server"),
 
 Review comment:
   I'm very confusion about the naming convention we used for the first two fields, eg., "1401"
and "STS01". The last 4 sql exceptions defined are totally out of orders which mightn't be
good.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message