phoenix-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] ChinmaySKulkarni commented on a change in pull request #428: PHOENIX-374: Enable access to dynamic columns in * or cf.* selection
Date Tue, 29 Jan 2019 07:45:50 GMT
ChinmaySKulkarni commented on a change in pull request #428: PHOENIX-374: Enable access to
dynamic columns in * or cf.* selection
URL: https://github.com/apache/phoenix/pull/428#discussion_r251720767
 
 

 ##########
 File path: phoenix-core/src/main/java/org/apache/phoenix/compile/ProjectionCompiler.java
 ##########
 @@ -501,7 +516,9 @@ public static RowProjector compile(StatementContext context, SelectStatement
sta
                 // Ignore as this can happen for local indexes when the data table has a
column family, but there are no covered columns in the family
             }
         }
-        return new RowProjector(projectedColumns, Math.max(estimatedKeySize, estimatedByteSize),
isProjectEmptyKeyValue, resolver.hasUDFs(), isWildcard);
+        return new RowProjector(projectedColumns, Math.max(estimatedKeySize, estimatedByteSize),
+                isProjectEmptyKeyValue, resolver.hasUDFs(), isWildcard,
+                isWildcard || !projectedFamilies.isEmpty());
 
 Review comment:
   This should actually be the `wildcardIncludesDynamicCols` check. Will change it.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message