phoenix-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] dbwong commented on a change in pull request #430: PHOENIX-5091 Add new features to UpdateStatisticsTool
Date Fri, 25 Jan 2019 23:59:24 GMT
dbwong commented on a change in pull request #430: PHOENIX-5091 Add new features to UpdateStatisticsTool
URL: https://github.com/apache/phoenix/pull/430#discussion_r251172563
 
 

 ##########
 File path: phoenix-core/src/main/java/org/apache/phoenix/schema/stats/UpdateStatisticsTool.java
 ##########
 @@ -190,9 +252,9 @@ private CommandLine parseOptions(String[] args) {
                     + "parameter");
         }
 
-        if (!cmdLine.hasOption(SNAPSHOT_NAME_OPTION.getOpt())) {
-            throw new IllegalStateException(SNAPSHOT_NAME_OPTION.getLongOpt() + " is a mandatory
"
-                    + "parameter");
+        if (cmdLine.hasOption(MANAGE_SNAPSHOT_OPTION.getOpt())
+                && !cmdLine.hasOption(RUN_FOREGROUND_OPTION.getOpt())) {
+            throw new IllegalStateException("Snapshot cannot be managed if job is running
in background");
 
 Review comment:
   We synced up off line, Karan will post a note on the JIRA but basically I was wondering
if there was any technical limitation to preventing a custom final reducer that handled the
clean up.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message