phoenix-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] twdsilva commented on a change in pull request #431: PHOENIX-5105
Date Tue, 22 Jan 2019 22:54:09 GMT
twdsilva commented on a change in pull request #431: PHOENIX-5105
URL: https://github.com/apache/phoenix/pull/431#discussion_r249992916
 
 

 ##########
 File path: phoenix-core/src/main/java/org/apache/phoenix/compile/JoinCompiler.java
 ##########
 @@ -761,13 +761,15 @@ public Expression compilePostFilterExpression(StatementContext context)
throws S
         }
 
         public SelectStatement getAsSubquery(List<OrderByNode> orderBy) throws SQLException
{
-            if (isSubselect())
-                return SubselectRewriter.applyOrderBy(
+            if (isSubselect()) {
+                return SubselectRewriter.applyOrderByAndPostFilters(
                         SubselectRewriter.applyPostFilters(subselect, preFilters, tableNode.getAlias()),
                         orderBy,
                         tableNode.getAlias(),
-                        tableNode);
-
+                        postFilters);
+            }
+            //for table, postFilters is empty , because it can safely pushed down as preFilters.
 
 Review comment:
   If there are ```postFilters``` will they always be pushed down into the sub query?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message