phoenix-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] karanmehta93 commented on a change in pull request #419: PHOENIX-4009 Run UPDATE STATISTICS command by using MR integration on…
Date Thu, 10 Jan 2019 00:32:58 GMT
karanmehta93 commented on a change in pull request #419: PHOENIX-4009 Run UPDATE STATISTICS
command by using MR integration on…
URL: https://github.com/apache/phoenix/pull/419#discussion_r246601068
 
 

 ##########
 File path: phoenix-core/src/main/java/org/apache/phoenix/mapreduce/util/PhoenixConfigurationUtil.java
 ##########
 @@ -154,7 +154,8 @@
 
     public enum SchemaType {
         TABLE,
-        QUERY;
+        QUERY,
+        UPDATE_STATS
 
 Review comment:
   > My point is that the meanings of QUERY and UPDATE_STATS have overlap
   
   They have some overlap. All of them are Phoenix MR job types. However Phoenix MR is generic
framework.
   `QUERY` suggests `Phoenix MR jobs` that allow you to run `arbitrary queries` (without aggregations)
   `UPDATE_STATS` suggests `Phoenix MR jobs` that will `collect statistics` (internally it
might run a fixed query)
   
   Depending on use case, the appropriate mappers/record readers/other MR components etc will
be called. 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message