From issues-return-3586-archive-asf-public=cust-asf.ponee.io@phoenix.apache.org Thu Dec 27 07:52:04 2018 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx-eu-01.ponee.io (Postfix) with SMTP id 4D58D180625 for ; Thu, 27 Dec 2018 07:52:04 +0100 (CET) Received: (qmail 25027 invoked by uid 500); 27 Dec 2018 06:52:03 -0000 Mailing-List: contact issues-help@phoenix.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@phoenix.apache.org Delivered-To: mailing list issues@phoenix.apache.org Received: (qmail 25016 invoked by uid 99); 27 Dec 2018 06:52:03 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd1-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 27 Dec 2018 06:52:03 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd1-us-west.apache.org (ASF Mail Server at spamd1-us-west.apache.org) with ESMTP id 15D48C55F4 for ; Thu, 27 Dec 2018 06:52:03 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd1-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -109.501 X-Spam-Level: X-Spam-Status: No, score=-109.501 tagged_above=-999 required=6.31 tests=[ENV_AND_HDR_SPF_MATCH=-0.5, KAM_ASCII_DIVIDERS=0.8, RCVD_IN_DNSWL_MED=-2.3, SPF_PASS=-0.001, USER_IN_DEF_SPF_WL=-7.5, USER_IN_WHITELIST=-100] autolearn=disabled Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd1-us-west.apache.org [10.40.0.7]) (amavisd-new, port 10024) with ESMTP id lZDcKkW_rzBt for ; Thu, 27 Dec 2018 06:52:01 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with ESMTP id 3802960E46 for ; Thu, 27 Dec 2018 06:52:01 +0000 (UTC) Received: from jira-lw-us.apache.org (unknown [207.244.88.139]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id BCFE7E0E87 for ; Thu, 27 Dec 2018 06:52:00 +0000 (UTC) Received: from jira-lw-us.apache.org (localhost [127.0.0.1]) by jira-lw-us.apache.org (ASF Mail Server at jira-lw-us.apache.org) with ESMTP id 771BD25360 for ; Thu, 27 Dec 2018 06:52:00 +0000 (UTC) Date: Thu, 27 Dec 2018 06:52:00 +0000 (UTC) From: "Monani Mihir (JIRA)" To: issues@phoenix.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (PHOENIX-5080) Index becomes Active during Partial Index Rebuilder if Index Failure happens MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/PHOENIX-5080?page=3Dcom.atlassi= an.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=3D16= 729385#comment-16729385 ]=20 Monani Mihir commented on PHOENIX-5080: --------------------------------------- {quote}=C2=A0I think for rebuilds (code path following rebuildIndices()), m= aybe we can skip updating the index state, and that way MetadataRegionObser= ver can handle the state transitions. {quote} With checks present in MetaDataEngPointImpl, like 1) if INDEX_STATE has bee= n changed during rebuild 2) INDEX_STATE is INACTIVE to successfully transit= ion into ACTIVE etc, Once rebuild is finished index will=C2=A0again transit= into DISABLE/PENDING_DISABLE state via MetaDataRegionObserver and we would= again run partial rebuilder.=C2=A0This cycle could repeat so many times.= =C2=A0 I think the more optimal solution would be that for each mutation until all= retires are exhausted (considering Partial Rebuilder as client) , we shoul= d not attempt to update INDEX_STATE , from INACTIVE to PENDING_DISABLE.=C2= =A0 {code:java} PhoenixIndexFailurePolicy#doBatchWithRetries :- while (canRetryMore(numRetry++, maxTries, canRetryUntil)) { try { Thread.sleep(ConnectionUtils.getPauseTime(pause, numRetry)); // HBase's exp= onential backoff mutateCommand.doMutation(); // success - change the index state from PENDING_DISABLE back to ACTIVE handleIndexWriteSuccessFromClient(iwe, connection); return; ...{code} In above code block when we call mutateCommand.doMutation(), we should not = attempt to update INDEX_STATE when failure occurs. Instead , once all retri= es are exhausted in while loop, we should=C2=A0DISABLE the index directly.= =C2=A0 What do you think [~vincentpoon] ?=C2=A0 I don't have much idea about UpsertSelect logic and how it works on server = side. =C2=A0 > Index becomes Active during Partial Index Rebuilder if Index Failure happ= ens > -------------------------------------------------------------------------= --- > > Key: PHOENIX-5080 > URL: https://issues.apache.org/jira/browse/PHOENIX-5080 > Project: Phoenix > Issue Type: Bug > Affects Versions: 4.14.1 > Reporter: Monani Mihir > Priority: Blocker > > After PHOENIX-4130=C2=A0and PHOENIX-4600=C2=A0, If there is Index failure= during Partial Index Rebuild, Rebuilder will try again to write Index upda= tes. If it succeeds then it will transition Index from INACTIVE to ACTIVE, = even before Rebuilder finishes. > Here is where it goes wrong, I think :-=C2=A0 > {code:java} > PhoenixIndexFailurePolicy.java :-=20 > public static void doBatchWithRetries(MutateCommand mutateCommand, > =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 IndexWriteException iwe, Phoeni= xConnection connection, ReadOnlyProps config) throws IOException { > .... > while (canRetryMore(numRetry++, maxTries, canRetryUntil)) { > ... > handleIndexWriteSuccessFromClient(iwe, connection); > ... > } > } > .... > private static void handleIndexWriteSuccessFromClient(IndexWriteException= indexWriteException, PhoenixConnection conn) { > =C2=A0 =C2=A0 =C2=A0 =C2=A0 handleExceptionFromClient(indexWriteException= , conn, PIndexState.ACTIVE); > } > {code} > =C2=A0 > =C2=A0 > =C2=A0 -- This message was sent by Atlassian JIRA (v7.6.3#76005)