From issues-return-3195-archive-asf-public=cust-asf.ponee.io@phoenix.apache.org Tue Dec 4 20:57:05 2018 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx-eu-01.ponee.io (Postfix) with SMTP id 0AC55180652 for ; Tue, 4 Dec 2018 20:57:04 +0100 (CET) Received: (qmail 11438 invoked by uid 500); 4 Dec 2018 19:57:04 -0000 Mailing-List: contact issues-help@phoenix.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@phoenix.apache.org Delivered-To: mailing list issues@phoenix.apache.org Received: (qmail 11429 invoked by uid 99); 4 Dec 2018 19:57:04 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd1-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 04 Dec 2018 19:57:04 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd1-us-west.apache.org (ASF Mail Server at spamd1-us-west.apache.org) with ESMTP id A71A8CB5B0 for ; Tue, 4 Dec 2018 19:57:03 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd1-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -109.501 X-Spam-Level: X-Spam-Status: No, score=-109.501 tagged_above=-999 required=6.31 tests=[ENV_AND_HDR_SPF_MATCH=-0.5, KAM_ASCII_DIVIDERS=0.8, RCVD_IN_DNSWL_MED=-2.3, SPF_PASS=-0.001, USER_IN_DEF_SPF_WL=-7.5, USER_IN_WHITELIST=-100] autolearn=disabled Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd1-us-west.apache.org [10.40.0.7]) (amavisd-new, port 10024) with ESMTP id 2cStk9EiUIb2 for ; Tue, 4 Dec 2018 19:57:02 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with ESMTP id B14EE60F4E for ; Tue, 4 Dec 2018 19:57:01 +0000 (UTC) Received: from jira-lw-us.apache.org (unknown [207.244.88.139]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id DA3ACE0E3E for ; Tue, 4 Dec 2018 19:57:00 +0000 (UTC) Received: from jira-lw-us.apache.org (localhost [127.0.0.1]) by jira-lw-us.apache.org (ASF Mail Server at jira-lw-us.apache.org) with ESMTP id 546452776F for ; Tue, 4 Dec 2018 19:57:00 +0000 (UTC) Date: Tue, 4 Dec 2018 19:57:00 +0000 (UTC) From: "ASF GitHub Bot (JIRA)" To: issues@phoenix.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (PHOENIX-5034) Log all critical statements in SYSTEM.LOG table. MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/PHOENIX-5034?page=3Dcom.atlassi= an.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=3D16= 709197#comment-16709197 ]=20 ASF GitHub Bot commented on PHOENIX-5034: ----------------------------------------- Github user xcangCRM commented on a diff in the pull request: https://github.com/apache/phoenix/pull/409#discussion_r238815424 =20 --- Diff: phoenix-core/src/main/java/org/apache/phoenix/log/QueryLogger= .java --- @@ -92,9 +92,17 @@ public boolean isSynced(){ } }; =20 - public static QueryLogger getInstance(PhoenixConnection connection= , boolean isSystemTable) { - if (connection.getLogLevel() =3D=3D LogLevel.OFF || isSystemTa= ble || ThreadLocalRandom.current() - .nextDouble() > connection.getLogSamplingRate()) { ret= urn NO_OP_INSTANCE; } + public static QueryLogger getInstance(PhoenixConnection connection= , boolean isSystemTable, + boolean criticalStatement) { + // always log critical statements (DROP,ALTER for now) + // do not log anything when loglevel is off. + // do not log systemTable statement. + // do sampling on other statements based on configured perncen= tage, 1% by default. --- End diff -- =20 fixed. Good eye. > Log all critical statements in SYSTEM.LOG table. > ------------------------------------------------ > > Key: PHOENIX-5034 > URL: https://issues.apache.org/jira/browse/PHOENIX-5034 > Project: Phoenix > Issue Type: Improvement > Reporter: Xu Cang > Assignee: Xu Cang > Priority: Minor > Attachments: PHOENIX-5034-4.x-HBase-1.3.001.patch, PHOENIX-5034-4= .x-HBase-1.3.002.patch, PHOENIX-5034-4.x-HBase-1.3.003.patch, PHOENIX-5034-= 4.x-HBase-1.3.004.patch, PHOENIX-5034-4.x-HBase-1.3.005.patch > > > In production,=C2=A0sometimes engineers see table got dropped unexpectedl= y. It's not easy to SCAN raw table from HBase itself to understand what hap= pened and when the table get dropped. > Since we already have SYSTEM.LOG query log facility in Phoenix that sampl= ing query statement (log 1% statement by default). It's good to always log = critical statements such as "DROP" or "ALTER" statements. > =C2=A0 -- This message was sent by Atlassian JIRA (v7.6.3#76005)