From issues-return-3349-archive-asf-public=cust-asf.ponee.io@phoenix.apache.org Thu Dec 13 12:36:05 2018 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx-eu-01.ponee.io (Postfix) with SMTP id 0D49F180609 for ; Thu, 13 Dec 2018 12:36:04 +0100 (CET) Received: (qmail 94669 invoked by uid 500); 13 Dec 2018 11:36:03 -0000 Mailing-List: contact issues-help@phoenix.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@phoenix.apache.org Delivered-To: mailing list issues@phoenix.apache.org Received: (qmail 94660 invoked by uid 99); 13 Dec 2018 11:36:03 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd3-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 13 Dec 2018 11:36:03 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd3-us-west.apache.org (ASF Mail Server at spamd3-us-west.apache.org) with ESMTP id 306F8180CC3 for ; Thu, 13 Dec 2018 11:36:03 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd3-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -109.501 X-Spam-Level: X-Spam-Status: No, score=-109.501 tagged_above=-999 required=6.31 tests=[ENV_AND_HDR_SPF_MATCH=-0.5, KAM_ASCII_DIVIDERS=0.8, RCVD_IN_DNSWL_MED=-2.3, SPF_PASS=-0.001, USER_IN_DEF_SPF_WL=-7.5, USER_IN_WHITELIST=-100] autolearn=disabled Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd3-us-west.apache.org [10.40.0.10]) (amavisd-new, port 10024) with ESMTP id lPpKtQavcZO6 for ; Thu, 13 Dec 2018 11:36:01 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with ESMTP id 258B35FADB for ; Thu, 13 Dec 2018 11:36:01 +0000 (UTC) Received: from jira-lw-us.apache.org (unknown [207.244.88.139]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id 6505CE0E87 for ; Thu, 13 Dec 2018 11:36:00 +0000 (UTC) Received: from jira-lw-us.apache.org (localhost [127.0.0.1]) by jira-lw-us.apache.org (ASF Mail Server at jira-lw-us.apache.org) with ESMTP id 1E06325320 for ; Thu, 13 Dec 2018 11:36:00 +0000 (UTC) Date: Thu, 13 Dec 2018 11:36:00 +0000 (UTC) From: "Hadoop QA (JIRA)" To: issues@phoenix.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (PHOENIX-4993) Data table region should not close RS level shared/cached connections like IndexWriter, RecoveryIndexWriter MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/PHOENIX-4993?page=3Dcom.atlassi= an.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=3D16= 720066#comment-16720066 ]=20 Hadoop QA commented on PHOENIX-4993: ------------------------------------ {color:red}-1 overall{color}. Here are the results of testing the latest a= ttachment=20 http://issues.apache.org/jira/secure/attachment/12951635/PHOENIX-4993-4.x= -HBase-1.3.02.patch against 4.x-HBase-1.3 branch at commit 1c042c25ed833945abe07958b82d5e9fb7= 01ac89. ATTACHMENT ID: 12951635 {color:green}+1 @author{color}. The patch does not contain any @author= tags. {color:green}+1 tests included{color}. The patch appears to include 3 = new or modified tests. {color:green}+1 javac{color}. The applied patch does not increase the = total number of javac compiler warnings. {color:red}-1 release audit{color}. The applied patch generated 1 rele= ase audit warnings (more than the master's current 0 warnings). {color:green}+1 lineLengths{color}. The patch does not introduce lines= longer than 100 {color:red}-1 core tests{color}. The patch failed these unit tests: ./phoenix-core/target/failsafe-reports/TEST-org.apache.phoenix.end2end= .IndexToolIT ./phoenix-core/target/failsafe-reports/TEST-org.apache.phoenix.end2end.join= .HashJoinMoreIT Test results: https://builds.apache.org/job/PreCommit-PHOENIX-Build/2206//t= estReport/ Release audit warnings: https://builds.apache.org/job/PreCommit-PHOENIX-Bui= ld/2206//artifact/patchprocess/patchReleaseAuditWarnings.txt Console output: https://builds.apache.org/job/PreCommit-PHOENIX-Build/2206/= /console This message is automatically generated. > Data table region should not close RS level shared/cached connections lik= e IndexWriter, RecoveryIndexWriter > -------------------------------------------------------------------------= ---------------------------------- > > Key: PHOENIX-4993 > URL: https://issues.apache.org/jira/browse/PHOENIX-4993 > Project: Phoenix > Issue Type: Bug > Affects Versions: 4.14.0 > Reporter: Kiran Kumar Maturi > Assignee: Kiran Kumar Maturi > Priority: Major > Attachments: PHOENIX-4993-4.x-HBase-1.3.01.patch, PHOENIX-4993-4.= x-HBase-1.3.02.patch > > > Issue is related to Region Server being killed when one region is closing= and another region is trying to write index updates. > When the data table region closes it will close region server level cache= d/shared connections and it could interrupt other region index/index-state = update. > -- Region1:=C2=A0Closing > {code:java} > TrackingParallellWriterIndexCommitter#stop() { > this.retryingFactory.shutdown(); > this.noRetriesFactory.shutdown(); > }{code} > closes the cached connections calling CoprocessorHConnectionTableFactory#= shutdown() in ServerUtil.java > =C2=A0 > --Region2: Writing index updates > Index updates fail as connections are closed, which leads to RejectedExec= utionException/Connection being null. This triggers=C2=A0PhoenixIndexFailur= ePolicy#handleFailureWithExceptions that tries to get the the syscat table = using the cached connections. Here it will not be able to reach to SYSCAT ,= so we will trigger KillServreFailurePolicy. > CoprocessorHConnectionTableFactory#getTable() > =C2=A0 > =C2=A0 > {code:java} > if (connection =3D=3D null || connection.isClosed()) { > throw new IllegalArgumentException("Connection is null or closed."); > }{code} > =C2=A0 > =C2=A0 -- This message was sent by Atlassian JIRA (v7.6.3#76005)