From issues-return-3182-archive-asf-public=cust-asf.ponee.io@phoenix.apache.org Tue Dec 4 20:40:05 2018 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx-eu-01.ponee.io (Postfix) with SMTP id 7F5D418067A for ; Tue, 4 Dec 2018 20:40:04 +0100 (CET) Received: (qmail 96860 invoked by uid 500); 4 Dec 2018 19:40:03 -0000 Mailing-List: contact issues-help@phoenix.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@phoenix.apache.org Delivered-To: mailing list issues@phoenix.apache.org Received: (qmail 96851 invoked by uid 99); 4 Dec 2018 19:40:03 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd4-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 04 Dec 2018 19:40:03 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd4-us-west.apache.org (ASF Mail Server at spamd4-us-west.apache.org) with ESMTP id 26087C2249 for ; Tue, 4 Dec 2018 19:40:03 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd4-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -109.501 X-Spam-Level: X-Spam-Status: No, score=-109.501 tagged_above=-999 required=6.31 tests=[ENV_AND_HDR_SPF_MATCH=-0.5, KAM_ASCII_DIVIDERS=0.8, RCVD_IN_DNSWL_MED=-2.3, SPF_PASS=-0.001, USER_IN_DEF_SPF_WL=-7.5, USER_IN_WHITELIST=-100] autolearn=disabled Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd4-us-west.apache.org [10.40.0.11]) (amavisd-new, port 10024) with ESMTP id MRpkNLuXQGzK for ; Tue, 4 Dec 2018 19:40:02 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with ESMTP id DBD5E5FB07 for ; Tue, 4 Dec 2018 19:40:01 +0000 (UTC) Received: from jira-lw-us.apache.org (unknown [207.244.88.139]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id 4D572E0E5D for ; Tue, 4 Dec 2018 19:40:01 +0000 (UTC) Received: from jira-lw-us.apache.org (localhost [127.0.0.1]) by jira-lw-us.apache.org (ASF Mail Server at jira-lw-us.apache.org) with ESMTP id 7BDCE27773 for ; Tue, 4 Dec 2018 19:40:00 +0000 (UTC) Date: Tue, 4 Dec 2018 19:40:00 +0000 (UTC) From: "ASF GitHub Bot (JIRA)" To: issues@phoenix.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (PHOENIX-4983) Allow using a connection with a SCN set to write data to tables EXCEPT transactional tables or mutable tables with indexes or tables with a ROW_TIMESTAMP column MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/PHOENIX-4983?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16709184#comment-16709184 ] ASF GitHub Bot commented on PHOENIX-4983: ----------------------------------------- Github user twdsilva commented on a diff in the pull request: https://github.com/apache/phoenix/pull/405#discussion_r238808710 --- Diff: phoenix-core/src/main/java/org/apache/phoenix/jdbc/PhoenixStatement.java --- @@ -399,8 +401,21 @@ public Integer call() throws SQLException { } MutationState state = connection.getMutationState(); MutationPlan plan = stmt.compilePlan(PhoenixStatement.this, Sequence.ValueOp.VALIDATE_SEQUENCE); - if (plan.getTargetRef() != null && plan.getTargetRef().getTable() != null && plan.getTargetRef().getTable().isTransactional()) { - state.startTransaction(plan.getTargetRef().getTable().getTransactionProvider()); + PTable table = plan.getTargetRef().getTable(); + if(table != null && connection.getSCN() != null && !connection.isRunningUpgrade() && !connection.isBuildingIndex()) { --- End diff -- can you move these checks to UpsertCompiler? Also I think you can remove the second check for mutable tables with indexes here. > Allow using a connection with a SCN set to write data to tables EXCEPT transactional tables or mutable tables with indexes or tables with a ROW_TIMESTAMP column > ---------------------------------------------------------------------------------------------------------------------------------------------------------------- > > Key: PHOENIX-4983 > URL: https://issues.apache.org/jira/browse/PHOENIX-4983 > Project: Phoenix > Issue Type: New Feature > Reporter: Thomas D'Silva > Assignee: Swaroopa Kadam > Priority: Major > Labels: SFDC > Attachments: PHOENIX-4983-4.x-HBase-1.4.patch > > > Currently If a SCN is set on a connection it is read-only. We only need to prevent a client from using a connection with a SCN set to upsert data for: > 1) transactional tables > 2) mutable tables with indexes > 3) tables with a ROW_TIMESTAMP column -- This message was sent by Atlassian JIRA (v7.6.3#76005)