From issues-return-3441-archive-asf-public=cust-asf.ponee.io@phoenix.apache.org  Tue Dec 18 19:25:16 2018
Return-Path: <issues-return-3441-archive-asf-public=cust-asf.ponee.io@phoenix.apache.org>
X-Original-To: archive-asf-public@cust-asf.ponee.io
Delivered-To: archive-asf-public@cust-asf.ponee.io
Received: from mail.apache.org (hermes.apache.org [140.211.11.3])
	by mx-eu-01.ponee.io (Postfix) with SMTP id 11A26180718
	for <archive-asf-public@cust-asf.ponee.io>; Tue, 18 Dec 2018 19:25:15 +0100 (CET)
Received: (qmail 56285 invoked by uid 500); 18 Dec 2018 18:25:15 -0000
Mailing-List: contact issues-help@phoenix.apache.org; run by ezmlm
Precedence: bulk
List-Help: <mailto:issues-help@phoenix.apache.org>
List-Unsubscribe: <mailto:issues-unsubscribe@phoenix.apache.org>
List-Post: <mailto:issues@phoenix.apache.org>
List-Id: <issues.phoenix.apache.org>
Reply-To: dev@phoenix.apache.org
Delivered-To: mailing list issues@phoenix.apache.org
Received: (qmail 56276 invoked by uid 99); 18 Dec 2018 18:25:15 -0000
Received: from git1-us-west.apache.org (HELO git1-us-west.apache.org) (140.211.11.23)
    by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 18 Dec 2018 18:25:15 +0000
Received: by git1-us-west.apache.org (ASF Mail Server at git1-us-west.apache.org, from userid 33)
	id 1AC4FE1444; Tue, 18 Dec 2018 18:25:15 +0000 (UTC)
From: twdsilva <git@git.apache.org>
To: issues@phoenix.apache.org
Reply-To: issues@phoenix.apache.org
References: <git-pr-418-phoenix@git.apache.org>
In-Reply-To: <git-pr-418-phoenix@git.apache.org>
Subject: [GitHub] phoenix pull request #418: [PHOENIX-3623] Integrate Omid with Phoenix.
Content-Type: text/plain
Message-Id: <20181218182515.1AC4FE1444@git1-us-west.apache.org>
Date: Tue, 18 Dec 2018 18:25:15 +0000 (UTC)

Github user twdsilva commented on a diff in the pull request:

    https://github.com/apache/phoenix/pull/418#discussion_r242645365
  
    --- Diff: phoenix-core/src/main/java/org/apache/phoenix/coprocessor/OmidTransactionalProcessor.java ---
    @@ -17,13 +17,16 @@
      */
     package org.apache.phoenix.coprocessor;
     
    -import org.apache.hadoop.hbase.coprocessor.BaseRegionObserver;
    +import org.apache.omid.transaction.OmidSnapshotFilter;
    +import org.apache.phoenix.transaction.OmidTransactionProvider;
     
     
     public class OmidTransactionalProcessor extends DelegateRegionObserver {
     
         public OmidTransactionalProcessor() {
    -        super(new BaseRegionObserver());
    +        // Hack for testing - retrieves the commit table client from the singleton OmidTransactionProvider
    +        // TODO: use real commit table and get port from config
    --- End diff --
    
    Does this comment need to be addressed?


---