From issues-return-3250-archive-asf-public=cust-asf.ponee.io@phoenix.apache.org  Wed Dec  5 23:10:23 2018
Return-Path: <issues-return-3250-archive-asf-public=cust-asf.ponee.io@phoenix.apache.org>
X-Original-To: archive-asf-public@cust-asf.ponee.io
Delivered-To: archive-asf-public@cust-asf.ponee.io
Received: from mail.apache.org (hermes.apache.org [140.211.11.3])
	by mx-eu-01.ponee.io (Postfix) with SMTP id 47FDD18067A
	for <archive-asf-public@cust-asf.ponee.io>; Wed,  5 Dec 2018 23:10:23 +0100 (CET)
Received: (qmail 15015 invoked by uid 500); 5 Dec 2018 22:10:22 -0000
Mailing-List: contact issues-help@phoenix.apache.org; run by ezmlm
Precedence: bulk
List-Help: <mailto:issues-help@phoenix.apache.org>
List-Unsubscribe: <mailto:issues-unsubscribe@phoenix.apache.org>
List-Post: <mailto:issues@phoenix.apache.org>
List-Id: <issues.phoenix.apache.org>
Reply-To: dev@phoenix.apache.org
Delivered-To: mailing list issues@phoenix.apache.org
Received: (qmail 14997 invoked by uid 99); 5 Dec 2018 22:10:22 -0000
Received: from git1-us-west.apache.org (HELO git1-us-west.apache.org) (140.211.11.23)
    by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 05 Dec 2018 22:10:22 +0000
Received: by git1-us-west.apache.org (ASF Mail Server at git1-us-west.apache.org, from userid 33)
	id 367BCE00AA; Wed,  5 Dec 2018 22:10:22 +0000 (UTC)
From: vincentpoon <git@git.apache.org>
To: issues@phoenix.apache.org
Reply-To: issues@phoenix.apache.org
References: <git-pr-411-phoenix@git.apache.org>
In-Reply-To: <git-pr-411-phoenix@git.apache.org>
Subject: [GitHub] phoenix pull request #411: PHOENIX-4832: Add Canary Test Tool for Phoenix Qu...
Content-Type: text/plain
Message-Id: <20181205221022.367BCE00AA@git1-us-west.apache.org>
Date: Wed,  5 Dec 2018 22:10:22 +0000 (UTC)

Github user vincentpoon commented on a diff in the pull request:

    https://github.com/apache/phoenix/pull/411#discussion_r239237418
  
    --- Diff: phoenix-core/pom.xml ---
    @@ -26,6 +26,7 @@
     
       <properties>
         <top.dir>${project.basedir}/..</top.dir>
    +    <argparse4j.version>0.8.1</argparse4j.version>
    --- End diff --
    
    don't think we need a separate property just to hold the version, as it's not used anywhere else?


---