phoenix-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Vincent Poon (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (PHOENIX-5071) Document Phoenix unit and IT testing APIs
Date Mon, 17 Dec 2018 19:08:00 GMT

    [ https://issues.apache.org/jira/browse/PHOENIX-5071?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16723275#comment-16723275
] 

Vincent Poon commented on PHOENIX-5071:
---------------------------------------

+1

I would also use this opportunity to put up some additional general "best practices" guidelines,
such as:
1)  Use unit tests and mocking wherever possible.  IT tests that require a mini cluster should
be a last resort, IMHO.  Unit tests are orders of magnitude faster and easier to debug.

2)  Never use Thread.sleep(), anywhere.  Wherever there's a Thread.sleep(), there's usually
non-deterministic behavior baked in, and we get flappers.

> Document Phoenix unit and IT testing APIs
> -----------------------------------------
>
>                 Key: PHOENIX-5071
>                 URL: https://issues.apache.org/jira/browse/PHOENIX-5071
>             Project: Phoenix
>          Issue Type: Improvement
>            Reporter: Geoffrey Jacoby
>            Priority: Major
>
> Phoenix has a complex set of test classes for use in setting up or sharing mini-clusters
for use in testing, but what they are and how/when to use them is mostly undocumented tribal
lore. This presents a barrier for new developers (and since they change over time can trip
up veteran ones too!) 



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Mime
View raw message