phoenix-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (PHOENIX-5025) Tool to clean up orphan views
Date Sat, 01 Dec 2018 19:54:00 GMT

    [ https://issues.apache.org/jira/browse/PHOENIX-5025?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16705976#comment-16705976
] 

ASF GitHub Bot commented on PHOENIX-5025:
-----------------------------------------

Github user kadirozde commented on a diff in the pull request:

    https://github.com/apache/phoenix/pull/404#discussion_r238074666
  
    --- Diff: phoenix-core/src/main/java/org/apache/phoenix/mapreduce/OrphanViewTool.java
---
    @@ -0,0 +1,812 @@
    +/*
    + * Licensed to the Apache Software Foundation (ASF) under one
    + * or more contributor license agreements.  See the NOTICE file
    + * distributed with this work for additional information
    + * regarding copyright ownership.  The ASF licenses this file
    + * to you under the Apache License, Version 2.0 (the
    + * "License"); you may not use this file except in compliance
    + * with the License.  You may obtain a copy of the License at
    + *
    + * http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing, software
    + * distributed under the License is distributed on an "AS IS" BASIS,
    + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    + * See the License for the specific language governing permissions and
    + * limitations under the License.
    + */
    +package org.apache.phoenix.mapreduce;
    --- End diff --
    
    I could not find a good place to move. Also, we may add M/R in future. 


> Tool to clean up orphan views
> -----------------------------
>
>                 Key: PHOENIX-5025
>                 URL: https://issues.apache.org/jira/browse/PHOENIX-5025
>             Project: Phoenix
>          Issue Type: New Feature
>            Reporter: Kadir OZDEMIR
>            Assignee: Kadir OZDEMIR
>            Priority: Major
>
> A view without its base table is an orphan view. Since views are virtual tables and their
data is stored in their base tables, they are useless when they become orphan. A base table
can have child views, grandchild views and so on. Due to some reasons/bugs, when a base table
was dropped, its views were not not properly cleaned up in the past. For example, the drop
table code did not support cleaning up grandchild views. This has been recently fixed by PHOENIX-4764. Although PHOENIX-4764
prevents new orphan views due to table drop operations, it does not clean up existing orphan
views. It is also believed that when the system catalog table was split due to a bug in the
past, it also contributed to creating orphan views as Phoenix did not support splittable system
catalog. Therefore, Phoenix needs a tool to clean up orphan views.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Mime
View raw message