phoenix-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hadoop QA (JIRA)" <>
Subject [jira] [Commented] (PHOENIX-4993) Data table region should not close RS level shared/cached connections like IndexWriter, RecoveryIndexWriter
Date Thu, 13 Dec 2018 11:36:00 GMT


Hadoop QA commented on PHOENIX-4993:

{color:red}-1 overall{color}.  Here are the results of testing the latest attachment
  against 4.x-HBase-1.3 branch at commit 1c042c25ed833945abe07958b82d5e9fb701ac89.
  ATTACHMENT ID: 12951635

    {color:green}+1 @author{color}.  The patch does not contain any @author tags.

    {color:green}+1 tests included{color}.  The patch appears to include 3 new or modified

    {color:green}+1 javac{color}.  The applied patch does not increase the total number of
javac compiler warnings.

    {color:red}-1 release audit{color}.  The applied patch generated 1 release audit warnings
(more than the master's current 0 warnings).

    {color:green}+1 lineLengths{color}.  The patch does not introduce lines longer than 100

     {color:red}-1 core tests{color}.  The patch failed these unit tests:

Test results:
Release audit warnings:
Console output:

This message is automatically generated.

> Data table region should not close RS level shared/cached connections like IndexWriter,
> -----------------------------------------------------------------------------------------------------------
>                 Key: PHOENIX-4993
>                 URL:
>             Project: Phoenix
>          Issue Type: Bug
>    Affects Versions: 4.14.0
>            Reporter: Kiran Kumar Maturi
>            Assignee: Kiran Kumar Maturi
>            Priority: Major
>         Attachments: PHOENIX-4993-4.x-HBase-1.3.01.patch, PHOENIX-4993-4.x-HBase-1.3.02.patch
> Issue is related to Region Server being killed when one region is closing and another
region is trying to write index updates.
> When the data table region closes it will close region server level cached/shared connections
and it could interrupt other region index/index-state update.
> -- Region1: Closing
> {code:java}
> TrackingParallellWriterIndexCommitter#stop() {
> this.retryingFactory.shutdown();
> this.noRetriesFactory.shutdown();
> }{code}
> closes the cached connections calling CoprocessorHConnectionTableFactory#shutdown() in
> --Region2: Writing index updates
> Index updates fail as connections are closed, which leads to RejectedExecutionException/Connection
being null. This triggers PhoenixIndexFailurePolicy#handleFailureWithExceptions that tries
to get the the syscat table using the cached connections. Here it will not be able to reach
to SYSCAT , so we will trigger KillServreFailurePolicy.
> CoprocessorHConnectionTableFactory#getTable()
> {code:java}
> if (connection == null || connection.isClosed()) {
> throw new IllegalArgumentException("Connection is null or closed.");
> }{code}

This message was sent by Atlassian JIRA

View raw message