phoenix-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (PHOENIX-4763) Changing a base table property value should be reflected in child views (if the property wasn't changed)
Date Sat, 01 Dec 2018 00:27:00 GMT

    [ https://issues.apache.org/jira/browse/PHOENIX-4763?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16705510#comment-16705510
] 

ASF GitHub Bot commented on PHOENIX-4763:
-----------------------------------------

Github user twdsilva commented on a diff in the pull request:

    https://github.com/apache/phoenix/pull/408#discussion_r238039864
  
    --- Diff: phoenix-core/src/main/java/org/apache/phoenix/coprocessor/MetaDataEndpointImpl.java
---
    @@ -1447,6 +1457,12 @@ private PTable getTable(RegionScanner scanner, long clientTimeStamp,
long tableT
             long updateCacheFrequency = updateCacheFrequencyKv == null ? 0 :
                 PLong.INSTANCE.getCodec().decodeLong(updateCacheFrequencyKv.getValueArray(),
                         updateCacheFrequencyKv.getValueOffset(), SortOrder.getDefault());
    +
    +        // Check the cell tag to see whether the view has modified this property
    +        byte[] tagUpdateCacheFreq = (updateCacheFrequencyKv == null) ? HConstants.EMPTY_BYTE_ARRAY
:
    +                TagUtil.concatTags(HConstants.EMPTY_BYTE_ARRAY, updateCacheFrequencyKv);
    --- End diff --
    
    Currently we only have a single cell tag, but just in case can you search if the byte[]
contains the tag insteads of starts with.


> Changing a base table property value should be reflected in child views (if the property
wasn't changed)
> --------------------------------------------------------------------------------------------------------
>
>                 Key: PHOENIX-4763
>                 URL: https://issues.apache.org/jira/browse/PHOENIX-4763
>             Project: Phoenix
>          Issue Type: Sub-task
>            Reporter: Thomas D'Silva
>            Assignee: Chinmay Kulkarni
>            Priority: Major
>
> .. for properties that are valid on views. 



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Mime
View raw message