phoenix-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hadoop QA (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (PHOENIX-4763) Changing a base table property value should be reflected in child views (if the property wasn't changed)
Date Sun, 09 Dec 2018 10:50:00 GMT

    [ https://issues.apache.org/jira/browse/PHOENIX-4763?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16713926#comment-16713926
] 

Hadoop QA commented on PHOENIX-4763:
------------------------------------

{color:red}-1 overall{color}.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12951112/PHOENIX-4763_v2.patch
  against master branch at commit 303fff09466bad5ab1e9aa0707c27d960fa5632d.
  ATTACHMENT ID: 12951112

    {color:green}+1 @author{color}.  The patch does not contain any @author tags.

    {color:green}+1 tests included{color}.  The patch appears to include 3 new or modified
tests.

    {color:green}+1 javac{color}.  The applied patch does not increase the total number of
javac compiler warnings.

    {color:red}-1 release audit{color}.  The applied patch generated 1 release audit warnings
(more than the master's current 0 warnings).

    {color:red}-1 lineLengths{color}.  The patch introduces the following lines longer than
100:
    +            PTable table = conn.unwrap(PhoenixConnection.class).getTable(new PTableKey(null,
tableName));
+            PTable viewTable2 = viewConn.unwrap(PhoenixConnection.class).getTable(new PTableKey(tenantId,
viewOfTable2));
+            viewTable2 = viewConn.unwrap(PhoenixConnection.class).getTable(new PTableKey(tenantId,
viewOfTable2));
+                        indexMaintainers.put(new ImmutableBytesWritable(index.getviewIndexIdType().toBytes(index.getViewIndexId())),
+        public MetaDataMutationResult(MutationCode returnCode, int currentTime, PTable table,
long viewIndexId, PDataType viewIndexIdType) {
+                sharedTableStateBuilder.setViewIndexIdType(sharedTableState.viewIndexIdType.getSqlType());
+              new java.lang.String[] { "TenantId", "SchemaName", "TableName", "Columns",
"PhysicalNames", "ViewIndexId", "ViewIndexIdType", });
+              new java.lang.String[] { "ReturnCode", "MutationTime", "Table", "TablesToDelete",
"ColumnName", "FamilyName", "FunctionName", "Function", "SharedTablesToDelete", "Schema",
"AutoPartitionNum", "ViewIndexId", "ViewIndexIdType", });
+      "pe\022\n\n\006SYSTEM\020\000\022\010\n\004USER\020\001\022\010\n\004VIEW\020\002\022\t\n\005IN"
+
+              new java.lang.String[] { "SchemaNameBytes", "TableNameBytes", "TableType",
"IndexState", "SequenceNumber", "TimeStamp", "PkNameBytes", "BucketNum", "Columns", "Indexes",
"IsImmutableRows", "DataTableNameBytes", "DefaultFamilyName", "DisableWAL", "MultiTenant",
"ViewType", "ViewStatement", "PhysicalNames", "TenantId", "ViewIndexId", "IndexType", "StatsTimeStamp",
"StoreNulls", "BaseColumnCount", "RowKeyOrderOptimizable", "Transactional", "UpdateCacheFrequency",
"IndexDisableTimestamp", "IsNamespaceMapped", "AutoParititonSeqName", "IsAppendOnlySchema",
"ParentNameBytes", "StorageScheme", "EncodingScheme", "EncodedCQCounters", "UseStatsForParallelization",
"TransactionProvider", "ViewIndexIdType", });

     {color:red}-1 core tests{color}.  The patch failed these unit tests:
     ./phoenix-core/target/failsafe-reports/TEST-org.apache.phoenix.end2end.ConcurrentMutationsIT
./phoenix-core/target/failsafe-reports/TEST-org.apache.phoenix.end2end.index.MutableIndexSplitReverseScanIT
./phoenix-core/target/failsafe-reports/TEST-org.apache.phoenix.end2end.index.MutableIndexSplitForwardScanIT

Test results: https://builds.apache.org/job/PreCommit-PHOENIX-Build/2195//testReport/
Release audit warnings: https://builds.apache.org/job/PreCommit-PHOENIX-Build/2195//artifact/patchprocess/patchReleaseAuditWarnings.txt
Console output: https://builds.apache.org/job/PreCommit-PHOENIX-Build/2195//console

This message is automatically generated.

> Changing a base table property value should be reflected in child views (if the property
wasn't changed)
> --------------------------------------------------------------------------------------------------------
>
>                 Key: PHOENIX-4763
>                 URL: https://issues.apache.org/jira/browse/PHOENIX-4763
>             Project: Phoenix
>          Issue Type: Sub-task
>            Reporter: Thomas D'Silva
>            Assignee: Chinmay Kulkarni
>            Priority: Major
>         Attachments: PHOENIX-4763.patch, PHOENIX-4763_v2.patch
>
>
> .. for properties that are valid on views. 



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Mime
View raw message