phoenix-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From twdsilva <...@git.apache.org>
Subject [GitHub] phoenix pull request #417: PHOENIX-4820
Date Fri, 21 Dec 2018 22:17:43 GMT
Github user twdsilva commented on a diff in the pull request:

    https://github.com/apache/phoenix/pull/417#discussion_r243703560
  
    --- Diff: phoenix-core/src/main/java/org/apache/phoenix/expression/Expression.java ---
    @@ -88,4 +88,10 @@
          * @return
          */
         boolean requiresFinalEvaluation();
    +
    --- End diff --
    
    As James said before its not clear to me why you need this new function, can just use
ExpressionUtil.isConstant() ?
    
    Your implementation returns true by default and is false only for AggregateFunction, RandomFunction
and SequenceValueExpression for which ExpressionUtil.isConstant() should also return false,
right?


---

Mime
View raw message