phoenix-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From JamesRTaylor <...@git.apache.org>
Subject [GitHub] phoenix pull request #418: [PHOENIX-3623] Integrate Omid with Phoenix.
Date Mon, 17 Dec 2018 16:47:21 GMT
Github user JamesRTaylor commented on a diff in the pull request:

    https://github.com/apache/phoenix/pull/418#discussion_r242225928
  
    --- Diff: phoenix-core/src/main/java/org/apache/phoenix/transaction/OmidTransactionProvider.java
---
    @@ -104,10 +204,15 @@ public Provider getProvider() {
         @Override
         public boolean isUnsupported(Feature feature) {
             return true;
    +        // return (
    +        //   feature == Feature.ALTER_NONTX_TO_TX || 
    +        //   feature == Feature.COLUMN_ENCODING || 
    +        //   feature == Feature.MAINTAIN_LOCAL_INDEX_ON_SERVER || 
    +        //   feature == Feature.SET_TTL);
    --- End diff --
    
    Please remove commented out code.


---

Mime
View raw message