phoenix-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From vincentpoon <...@git.apache.org>
Subject [GitHub] phoenix pull request #411: PHOENIX-4832: Add Canary Test Tool for Phoenix Qu...
Date Wed, 05 Dec 2018 22:10:22 GMT
Github user vincentpoon commented on a diff in the pull request:

    https://github.com/apache/phoenix/pull/411#discussion_r239237418
  
    --- Diff: phoenix-core/pom.xml ---
    @@ -26,6 +26,7 @@
     
       <properties>
         <top.dir>${project.basedir}/..</top.dir>
    +    <argparse4j.version>0.8.1</argparse4j.version>
    --- End diff --
    
    don't think we need a separate property just to hold the version, as it's not used anywhere
else?


---

Mime
View raw message