phoenix-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From karanmehta93 <...@git.apache.org>
Subject [GitHub] phoenix pull request #410: PHOENIX-5034 Log all critical statements in SYSTE...
Date Wed, 05 Dec 2018 00:47:51 GMT
Github user karanmehta93 commented on a diff in the pull request:

    https://github.com/apache/phoenix/pull/410#discussion_r238895706
  
    --- Diff: phoenix-core/src/it/java/org/apache/phoenix/end2end/QueryLoggerIT.java ---
    @@ -250,7 +250,103 @@ public void testWithLoggingOFF() throws Exception{
             assertFalse(foundQueryLog);
             conn.close();
         }
    -    
    +
    +    @Test
    +    //DROP Table statement should be always logged.
    +    public void testDropTableStatement() throws Exception{
    --- End diff --
    
    Sorry for late comment but you can actually merge both the tests into on.


---

Mime
View raw message