phoenix-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From karanmehta93 <...@git.apache.org>
Subject [GitHub] phoenix pull request #409: PHOENIX-5034 Log all critical statements in SYSTE...
Date Tue, 04 Dec 2018 02:19:23 GMT
Github user karanmehta93 commented on a diff in the pull request:

    https://github.com/apache/phoenix/pull/409#discussion_r238509758
  
    --- Diff: phoenix-core/src/main/java/org/apache/phoenix/log/QueryLogger.java ---
    @@ -92,9 +92,17 @@ public boolean isSynced(){
             }
         };
     
    -    public static QueryLogger getInstance(PhoenixConnection connection, boolean isSystemTable)
{
    -        if (connection.getLogLevel() == LogLevel.OFF || isSystemTable || ThreadLocalRandom.current()
    -                .nextDouble() > connection.getLogSamplingRate()) { return NO_OP_INSTANCE;
}
    +    public static QueryLogger getInstance(PhoenixConnection connection, boolean isSystemTable,
    --- End diff --
    
    Should we rename this to `createInstance` so that it doesn't feel like we are returning
a singleton? 


---

Mime
View raw message