phoenix-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From kadirozde <...@git.apache.org>
Subject [GitHub] phoenix pull request #404: PHOENIX-5025 Tool to clean up orphan views
Date Sat, 01 Dec 2018 19:53:42 GMT
Github user kadirozde commented on a diff in the pull request:

    https://github.com/apache/phoenix/pull/404#discussion_r238074562
  
    --- Diff: phoenix-core/src/it/java/org/apache/phoenix/end2end/OrphanViewToolIT.java ---
    @@ -0,0 +1,456 @@
    +/*
    + * Licensed to the Apache Software Foundation (ASF) under one
    + * or more contributor license agreements.  See the NOTICE file
    + * distributed with this work for additional information
    + * regarding copyright ownership.  The ASF licenses this file
    + * to you under the Apache License, Version 2.0 (the
    + * "License"); you may not use this file except in compliance
    + * with the License.  You may obtain a copy of the License at
    + *
    + * http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing, software
    + * distributed under the License is distributed on an "AS IS" BASIS,
    + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    + * See the License for the specific language governing permissions and
    + * limitations under the License.
    + */
    +package org.apache.phoenix.end2end;
    +
    +import static org.apache.phoenix.jdbc.PhoenixDatabaseMetaData.LINK_TYPE;
    +import static org.apache.phoenix.jdbc.PhoenixDatabaseMetaData.SYSTEM_CATALOG_NAME;
    +import static org.apache.phoenix.jdbc.PhoenixDatabaseMetaData.SYSTEM_CHILD_LINK_NAME;
    +import static org.apache.phoenix.jdbc.PhoenixDatabaseMetaData.TABLE_NAME;
    +import static org.apache.phoenix.jdbc.PhoenixDatabaseMetaData.TABLE_SCHEM;
    +import static org.apache.phoenix.jdbc.PhoenixDatabaseMetaData.TABLE_TYPE;
    +import static org.apache.phoenix.util.PhoenixRuntime.TENANT_ID_ATTRIB;
    +import static org.junit.Assert.assertEquals;
    +import static org.junit.Assert.assertTrue;
    +
    +import java.io.IOException;
    +import java.nio.file.Files;
    +import java.nio.file.Paths;
    +import java.sql.Connection;
    +import java.sql.DriverManager;
    +import java.sql.ResultSet;
    +import java.sql.SQLException;
    +import java.util.Arrays;
    +import java.util.Collection;
    +import java.util.List;
    +
    +import com.google.common.collect.Lists;
    +import org.apache.hadoop.conf.Configuration;
    +import org.apache.phoenix.jdbc.PhoenixDatabaseMetaData;
    +import org.apache.phoenix.mapreduce.OrphanViewTool;
    +import org.apache.phoenix.schema.PTable;
    +import org.apache.phoenix.schema.PTableType;
    +import org.apache.phoenix.util.SchemaUtil;
    +import org.junit.Test;
    +import org.junit.runner.RunWith;
    +import org.junit.runners.Parameterized;
    +import org.junit.runners.Parameterized.Parameters;
    +import org.slf4j.Logger;
    +import org.slf4j.LoggerFactory;
    +
    +@RunWith(Parameterized.class)
    +public class OrphanViewToolIT extends ParallelStatsDisabledIT {
    +    private static final Logger LOG = LoggerFactory.getLogger(OrphanViewToolIT.class);
    +
    +    private final boolean isMultiTenant;
    +    private final boolean columnEncoded;
    +
    +    private static final int fanout = 2;
    +
    +    private static final String filePath = "/tmp/";
    +    private static final String fileName = "/tmp/OrphanView.txt";
    --- End diff --
    
    Good suggestion.


---

Mime
View raw message