phoenix-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Chinmay Kulkarni (Jira)" <j...@apache.org>
Subject [jira] [Created] (PHOENIX-6085) Remove duplicate calls to getSysMutexPhysicalTableNameBytes() during the upgrade path
Date Wed, 19 Aug 2020 19:12:00 GMT
Chinmay Kulkarni created PHOENIX-6085:
-----------------------------------------

             Summary: Remove duplicate calls to getSysMutexPhysicalTableNameBytes() during
the upgrade path
                 Key: PHOENIX-6085
                 URL: https://issues.apache.org/jira/browse/PHOENIX-6085
             Project: Phoenix
          Issue Type: Improvement
    Affects Versions: 4.15.0, 5.0.0
            Reporter: Chinmay Kulkarni
             Fix For: 5.1.0, 4.16.0


We already make this call inside [CQSI.acquireUpgradeMutex()|https://github.com/apache/phoenix/blob/1922895dfe5960dc025709b04acfaf974d3959dc/phoenix-core/src/main/java/org/apache/phoenix/query/ConnectionQueryServicesImpl.java#L4220]
and then call writeMutexCell() which calls this again [here|https://github.com/apache/phoenix/blob/1922895dfe5960dc025709b04acfaf974d3959dc/phoenix-core/src/main/java/org/apache/phoenix/query/ConnectionQueryServicesImpl.java#L4244].


We should move this to inside writeMutexCell() itself and throw UpgradeInProgressException
if required there to avoid unnecessary expensive HBase admin API calls.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Mime
View raw message