From dev-return-61332-archive-asf-public=cust-asf.ponee.io@phoenix.apache.org Thu Jun 4 18:05:03 2020 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [207.244.88.153]) by mx-eu-01.ponee.io (Postfix) with SMTP id C25CE180665 for ; Thu, 4 Jun 2020 20:05:02 +0200 (CEST) Received: (qmail 68019 invoked by uid 500); 4 Jun 2020 18:05:02 -0000 Mailing-List: contact dev-help@phoenix.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@phoenix.apache.org Delivered-To: mailing list dev@phoenix.apache.org Received: (qmail 67805 invoked by uid 99); 4 Jun 2020 18:05:01 -0000 Received: from mailrelay1-us-west.apache.org (HELO mailrelay1-us-west.apache.org) (209.188.14.139) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 04 Jun 2020 18:05:01 +0000 Received: from jira-he-de.apache.org (static.172.67.40.188.clients.your-server.de [188.40.67.172]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id DAC6A41133 for ; Thu, 4 Jun 2020 18:05:00 +0000 (UTC) Received: from jira-he-de.apache.org (localhost.localdomain [127.0.0.1]) by jira-he-de.apache.org (ASF Mail Server at jira-he-de.apache.org) with ESMTP id 3BFEB78078E for ; Thu, 4 Jun 2020 18:05:00 +0000 (UTC) Date: Thu, 4 Jun 2020 18:05:00 +0000 (UTC) From: "Neha Gupta (Jira)" To: dev@phoenix.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Updated] (PHOENIX-5920) Skip SYSTEM TABLE checks while creating phoenix connection if client has set the DoNotUpgrade config MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/PHOENIX-5920?page=3Dcom.atlass= ian.jira.plugin.system.issuetabpanels:all-tabpanel ] Neha Gupta updated PHOENIX-5920: -------------------------------- Attachment: PHOENIX-5920.v3.patch > Skip SYSTEM TABLE checks while creating phoenix connection if client has = set the DoNotUpgrade config > -------------------------------------------------------------------------= --------------------------- > > Key: PHOENIX-5920 > URL: https://issues.apache.org/jira/browse/PHOENIX-5920 > Project: Phoenix > Issue Type: Bug > Affects Versions: 5.0.0, 4.15.0, 4.14.3 > Reporter: Neha Gupta > Assignee: Neha Gupta > Priority: Major > Fix For: 5.1.0, 4.16.0 > > Attachments: PHOENIX-5920.patch, PHOENIX-5920.v1.patch, PHOENIX-5= 920.v2.patch, PHOENIX-5920.v3.patch > > Time Spent: 2h > Remaining Estimate: 0h > > Phoenix checks upgrade path even if client has set "DoNotUpgrade" config.= When HMaster failover happens and Phoenix client creating phoenix connecti= on, we get exception "org.apache.hadoop.hbase.PleaseHoldException: Master i= s initializing" because phoenix calls HBase admin apis to check if SYSTEM t= ables are in place and does not require an upgrade.=C2=A0=C2=A0[CQSI.init()= |https://github.com/apache/phoenix/blob/aad583670ea821286ab5e2460ce0ab7255d= 474c4/phoenix-core/src/main/java/org/apache/phoenix/query/ConnectionQuerySe= rvicesImpl.java#L3169]=C2=A0initiates creating systems table and=C2=A0[CQSI= .ensureTableCreated|https://github.com/apache/phoenix/blob/aad583670ea82128= 6ab5e2460ce0ab7255d474c4/phoenix-core/src/main/java/org/apache/phoenix/quer= y/ConnectionQueryServicesImpl.java#L1246]=C2=A0is checking if SYTEM table r= equires upgrade and calls hbaseAdminApis to perform this operation which fa= ils if HMaster is not running. Can we honor the=C2=A0"DoNotUpgrade" config = by client(By making an assumption that SYSTEM table is already up-to-date a= nd phoenix client shouldn't perform any upgrades) and skip this upgrade che= cks ? > EnsureTableCreated performs bunch of client-server compatibility checks l= ike: > 1.SYSTEM.CATALOG exists and its timestamp < MIN_SYSTEM_TABLE_TIMESTAMP > 2.SYSTEM.CATALOG exists, but client and server-side namespace mapping is = enabled so we need to migrate SYSTEM tables to the SYSTEM namespace > 3.When an end-user uses the vanilla PhoenixDriver to create a connection = and a requirement for upgrade is detected. In this case, the user should ge= t a connection on which they are only able to run "EXECUTE UPGRADE". -- This message was sent by Atlassian Jira (v8.3.4#803005)