From dev-return-60128-archive-asf-public=cust-asf.ponee.io@phoenix.apache.org Thu Feb 27 19:10:02 2020 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [207.244.88.153]) by mx-eu-01.ponee.io (Postfix) with SMTP id 38D70180181 for ; Thu, 27 Feb 2020 20:10:02 +0100 (CET) Received: (qmail 820 invoked by uid 500); 27 Feb 2020 19:10:01 -0000 Mailing-List: contact dev-help@phoenix.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@phoenix.apache.org Delivered-To: mailing list dev@phoenix.apache.org Received: (qmail 808 invoked by uid 99); 27 Feb 2020 19:10:01 -0000 Received: from mailrelay1-us-west.apache.org (HELO mailrelay1-us-west.apache.org) (209.188.14.139) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 27 Feb 2020 19:10:01 +0000 Received: from jira-he-de.apache.org (static.172.67.40.188.clients.your-server.de [188.40.67.172]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id DC720E07DE for ; Thu, 27 Feb 2020 19:10:00 +0000 (UTC) Received: from jira-he-de.apache.org (localhost.localdomain [127.0.0.1]) by jira-he-de.apache.org (ASF Mail Server at jira-he-de.apache.org) with ESMTP id 5A99178008E for ; Thu, 27 Feb 2020 19:10:00 +0000 (UTC) Date: Thu, 27 Feb 2020 19:10:00 +0000 (UTC) From: "Neha Gupta (Jira)" To: dev@phoenix.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Updated] (PHOENIX-5496) Ensure that we handle all server-side mutation codes on the client MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/PHOENIX-5496?page=3Dcom.atlass= ian.jira.plugin.system.issuetabpanels:all-tabpanel ] Neha Gupta updated PHOENIX-5496: -------------------------------- Attachment: PHOENIX-5496.4.x-HBase-1.3.patch > Ensure that we handle all server-side mutation codes on the client > ------------------------------------------------------------------ > > Key: PHOENIX-5496 > URL: https://issues.apache.org/jira/browse/PHOENIX-5496 > Project: Phoenix > Issue Type: Bug > Affects Versions: 4.15.0, 5.1.0 > Reporter: Chinmay Kulkarni > Assignee: Neha Gupta > Priority: Major > Fix For: 4.15.1, 5.1.1 > > Attachments: PHOENIX-5496.4.x-HBase-1.3.patch, PHOENIX-5496.maste= r.patch, PHOENIX-5496.patch, PHOENIX-5496.v1.patch, PHOENIX-5496.v2.patch, = PHOENIX-5496.v3.patch > > Time Spent: 3h 50m > Remaining Estimate: 0h > > There are many instances throughout wherein we set a certain error mutati= on code in the RPC callback, however we do not handle these mutation codes = on the client. > For example:=C2=A0 > If the metadata rows for a tableKey are no longer in that SYSCAT region, = checkTableKeyInRegion() fails, the metadata for this table is not written t= o SYSCAT and=C2=A0[the TABLE_NOT_IN_REGION mutation code is set|https://git= hub.com/apache/phoenix/blob/11997d48d1957cf613526f01c5ccbe2812cf095d/phoeni= x-core/src/main/java/org/apache/phoenix/coprocessor/MetaDataEndpointImpl.ja= va#L1785-L1790]. > This is handled for 1 retry inside=C2=A0[CQSI.metaDataCoprocessorExec|htt= ps://github.com/apache/phoenix/blob/11997d48d1957cf613526f01c5ccbe2812cf095= d/phoenix-core/src/main/java/org/apache/phoenix/query/ConnectionQueryServic= esImpl.java#L1568-L1570], but if this happens again, it is returned back to= the client where it goes to the default case and succeeds. > Apart from the fact that partial metadata updates are possible leading to= orphan metadata rows in system tables, this also wrongly returns success f= or clients even though there is no record of that table/view being created = inside Phoenix's system tables. -- This message was sent by Atlassian Jira (v8.3.4#803005)