phoenix-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Geoffrey Jacoby (Jira)" <j...@apache.org>
Subject [jira] [Reopened] (PHOENIX-5677) Replace System.currentTimeMillis with EnvironmentEdgeManager in non-test code
Date Wed, 22 Jan 2020 19:41:00 GMT

     [ https://issues.apache.org/jira/browse/PHOENIX-5677?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Geoffrey Jacoby reopened PHOENIX-5677:
--------------------------------------

Broke IndexScrutinyIT tests because of infinite recursion. Missed this because Phoenix Jenkins
was broken for a few days, and I mistakenly thought I'd verified this locally. My apologies.


> Replace System.currentTimeMillis with EnvironmentEdgeManager in non-test code
> -----------------------------------------------------------------------------
>
>                 Key: PHOENIX-5677
>                 URL: https://issues.apache.org/jira/browse/PHOENIX-5677
>             Project: Phoenix
>          Issue Type: Bug
>            Reporter: Geoffrey Jacoby
>            Assignee: Geoffrey Jacoby
>            Priority: Major
>             Fix For: 5.1.0, 4.16.0
>
>         Attachments: PHOENIX-5677-4.x-HBase-1.3.patch
>
>          Time Spent: 0.5h
>  Remaining Estimate: 0h
>
> Phoenix is inconsistent in using either system clock or EnvironmentEdgeManager to get
current time. The EnvironmentEdgeManager is occasionally very useful in tests to control time
deterministically without needing to sleep. Direct references to System.currentTimeMillis
in non-test code should be switched over. 



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Mime
View raw message