phoenix-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Geoffrey Jacoby (Jira)" <j...@apache.org>
Subject [jira] [Updated] (PHOENIX-5541) Redundant Global Mutable Index Writes on Legacy Indexer
Date Mon, 28 Oct 2019 20:49:00 GMT

     [ https://issues.apache.org/jira/browse/PHOENIX-5541?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Geoffrey Jacoby updated PHOENIX-5541:
-------------------------------------
    Fix Version/s: 4.15.1
                   5.1.0
                   4.14.4

> Redundant Global Mutable Index Writes on Legacy Indexer
> -------------------------------------------------------
>
>                 Key: PHOENIX-5541
>                 URL: https://issues.apache.org/jira/browse/PHOENIX-5541
>             Project: Phoenix
>          Issue Type: Bug
>    Affects Versions: 4.15.0, 5.1.0, 4.14.3
>            Reporter: Geoffrey Jacoby
>            Assignee: Geoffrey Jacoby
>            Priority: Major
>             Fix For: 5.1.0, 4.15.1, 4.14.4
>
>         Attachments: PHOENIX-5541.patch
>
>          Time Spent: 40m
>  Remaining Estimate: 0h
>
> In the inaccurately-named IndexWriter.writeAndKillYourselfOnFailure, there's the following
code:
> {code:java}
> public void writeAndKillYourselfOnFailure(Collection<Pair<Mutation, byte[]>>
indexUpdates, boolean allowLocalUpdates, int clientVersion) throws IOException { 
> // convert the strings to htableinterfaces to which we can talk and group by TABLE Multimap<HTableInterfaceReference,
Mutation> toWrite = resolveTableReferences(indexUpdates); 
> writeAndKillYourselfOnFailure(toWrite, allowLocalUpdates, clientVersion); writeAndHandleFailure(toWrite,
allowLocalUpdates, clientVersion); 
> }
> {code}
> writeAndKillYourselfOnFailure and writeAndHandleFailure seem to be identical, which means
that calling them both will result in the same index Cells being written twice. This shouldn't
affect correctness, but it will affect performance and (temporarily, until compaction) storage



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Mime
View raw message