From dev-return-57669-archive-asf-public=cust-asf.ponee.io@phoenix.apache.org Wed Jul 31 21:49:06 2019 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [207.244.88.153]) by mx-eu-01.ponee.io (Postfix) with SMTP id 72B9D18062B for ; Wed, 31 Jul 2019 23:49:06 +0200 (CEST) Received: (qmail 10053 invoked by uid 500); 31 Jul 2019 21:49:02 -0000 Mailing-List: contact dev-help@phoenix.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@phoenix.apache.org Delivered-To: mailing list dev@phoenix.apache.org Received: (qmail 9955 invoked by uid 99); 31 Jul 2019 21:49:02 -0000 Received: from mailrelay1-us-west.apache.org (HELO mailrelay1-us-west.apache.org) (209.188.14.139) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 31 Jul 2019 21:49:02 +0000 Received: from jira-lw-us.apache.org (unknown [207.244.88.139]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id 12C8DE2F90 for ; Wed, 31 Jul 2019 21:49:01 +0000 (UTC) Received: from jira-lw-us.apache.org (localhost [127.0.0.1]) by jira-lw-us.apache.org (ASF Mail Server at jira-lw-us.apache.org) with ESMTP id 74E1E26648 for ; Wed, 31 Jul 2019 21:49:00 +0000 (UTC) Date: Wed, 31 Jul 2019 21:49:00 +0000 (UTC) From: "Daniel Wong (JIRA)" To: dev@phoenix.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Updated] (PHOENIX-5142) Protect against bad scan construction causing stack overflow MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/PHOENIX-5142?page=3Dcom.atlass= ian.jira.plugin.system.issuetabpanels:all-tabpanel ] Daniel Wong updated PHOENIX-5142: --------------------------------- Affects Version/s: 4.15.0 > Protect against bad scan construction causing stack overflow > ------------------------------------------------------------ > > Key: PHOENIX-5142 > URL: https://issues.apache.org/jira/browse/PHOENIX-5142 > Project: Phoenix > Issue Type: Improvement > Affects Versions: 4.15.0, 5.1.0 > Reporter: Daniel Wong > Priority: Minor > Labels: beginner, newbie > Fix For: 5.1.0 > > > During implementation changes I created an issue where a bad set of scans= were generated.=C2=A0 These scans crossed region boundaries incorrectly.= =C2=A0 This led Phoenix to believe the cache was out of date and triggered = a retry attempt in a recursive manner until the stack overflowed.=C2=A0 We = may want to protect against this type of failure by limiting the depth of t= he recursion and returning an exception to the user. > {code:java} > java.lang.StackOverflowError at java.security.AccessController.doPrivileg= ed(Native Method) at java.io.PrintWriter.(PrintWriter.java:116) at ja= va.io.PrintWriter.(PrintWriter.java:100) at org.apache.log4j.DefaultT= hrowableRenderer.render(DefaultThrowableRenderer.java:58) at org.apache.log= 4j.spi.ThrowableInformation.getThrowableStrRep(ThrowableInformation.java:87= ) at org.apache.log4j.spi.LoggingEvent.getThrowableStrRep(LoggingEvent.java= :413) at org.apache.log4j.WriterAppender.subAppend(WriterAppender.java:313)= at org.apache.log4j.WriterAppender.append(WriterAppender.java:162) at org.= apache.log4j.AppenderSkeleton.doAppend(AppenderSkeleton.java:251) at org.ap= ache.log4j.helpers.AppenderAttachableImpl.appendLoopOnAppenders(AppenderAtt= achableImpl.java:66) at org.apache.log4j.Category.callAppenders(Category.ja= va:206) at org.apache.log4j.Category.forcedLog(Category.java:391) at org.ap= ache.log4j.Category.log(Category.java:856) at org.slf4j.impl.Log4jLoggerAda= pter.info(Log4jLoggerAdapter.java:382) at org.apache.phoenix.iterate.BaseRe= sultIterators.close(BaseResultIterators.java:1568) at org.apache.phoenix.it= erate.BaseResultIterators.getIterators(BaseResultIterators.java:1475) at or= g.apache.phoenix.iterate.BaseResultIterators.recreateIterators(BaseResultIt= erators.java:1523) at org.apache.phoenix.iterate.BaseResultIterators.getIte= rators(BaseResultIterators.java:1441) at org.apache.phoenix.iterate.BaseRes= ultIterators.recreateIterators(BaseResultIterators.java:1523) at org.apache= .phoenix.iterate.BaseResultIterators.getIterators(BaseResultIterators.java:= 1441) at org.apache.phoenix.iterate.BaseResultIterators.recreateIterators(B= aseResultIterators.java:1523) at org.apache.phoenix.iterate.BaseResultItera= tors.getIterators(BaseResultIterators.java:1441) at org.apache.phoenix.iter= ate.BaseResultIterators.recreateIterators(BaseResultIterators.java:1523) at= org.apache.phoenix.iterate.BaseResultIterators.getIterators(BaseResultIter= ators.java:1441) at org.apache.phoenix.iterate.BaseResultIterators.recreate= Iterators(BaseResultIterators.java:1523) at org.apache.phoenix.iterate.Base= ResultIterators.getIterators(BaseResultIterators.java:1441) > .... > {code} -- This message was sent by Atlassian JIRA (v7.6.14#76016)