From dev-return-56583-archive-asf-public=cust-asf.ponee.io@phoenix.apache.org Thu May 23 18:08:03 2019 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [207.244.88.153]) by mx-eu-01.ponee.io (Postfix) with SMTP id C0C5818062F for ; Thu, 23 May 2019 20:08:02 +0200 (CEST) Received: (qmail 94575 invoked by uid 500); 23 May 2019 18:08:02 -0000 Mailing-List: contact dev-help@phoenix.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@phoenix.apache.org Delivered-To: mailing list dev@phoenix.apache.org Received: (qmail 94554 invoked by uid 99); 23 May 2019 18:08:01 -0000 Received: from mailrelay1-us-west.apache.org (HELO mailrelay1-us-west.apache.org) (209.188.14.139) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 23 May 2019 18:08:01 +0000 Received: from jira-lw-us.apache.org (unknown [207.244.88.139]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id 44009E2C8F for ; Thu, 23 May 2019 18:08:01 +0000 (UTC) Received: from jira-lw-us.apache.org (localhost [127.0.0.1]) by jira-lw-us.apache.org (ASF Mail Server at jira-lw-us.apache.org) with ESMTP id 57BBB25819 for ; Thu, 23 May 2019 18:08:00 +0000 (UTC) Date: Thu, 23 May 2019 18:08:00 +0000 (UTC) From: "Andrew Purtell (JIRA)" To: dev@phoenix.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Updated] (PHOENIX-5296) Ensure store file reader refcount is zero at end of relevant unit tests MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/PHOENIX-5296?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrew Purtell updated PHOENIX-5296: ------------------------------------ Description: Unit and integration tests for functional areas where the implementation wraps scanners and uses a delegate pattern should check at the end of the test that no scanners were leaked (check that all scanners including the inner scanners were properly closed) by testing that the store reader reference count is zero on all stores. HBASE-22459 will offer a new metric and API which exposes this information. was: Unit and integration tests for functional areas where the implementation wraps scanners and uses a delegate pattern should check at the end of the test that no scanners were leaked (check that all scanners were properly closed) by testing that the store reader reference count is zero on all stores. HBASE-22459 will offer a new metric and API which exposes this information. > Ensure store file reader refcount is zero at end of relevant unit tests > ----------------------------------------------------------------------- > > Key: PHOENIX-5296 > URL: https://issues.apache.org/jira/browse/PHOENIX-5296 > Project: Phoenix > Issue Type: Test > Reporter: Andrew Purtell > Priority: Major > > Unit and integration tests for functional areas where the implementation wraps scanners and uses a delegate pattern should check at the end of the test that no scanners were leaked (check that all scanners including the inner scanners were properly closed) by testing that the store reader reference count is zero on all stores. > HBASE-22459 will offer a new metric and API which exposes this information. -- This message was sent by Atlassian JIRA (v7.6.3#76005)