From dev-return-56325-apmail-phoenix-dev-archive=phoenix.apache.org@phoenix.apache.org Fri May 3 02:25:07 2019 Return-Path: X-Original-To: apmail-phoenix-dev-archive@minotaur.apache.org Delivered-To: apmail-phoenix-dev-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [207.244.88.153]) by minotaur.apache.org (Postfix) with SMTP id 4FF9419269 for ; Fri, 3 May 2019 02:25:06 +0000 (UTC) Received: (qmail 4873 invoked by uid 500); 3 May 2019 02:25:02 -0000 Delivered-To: apmail-phoenix-dev-archive@phoenix.apache.org Received: (qmail 4835 invoked by uid 500); 3 May 2019 02:25:02 -0000 Mailing-List: contact dev-help@phoenix.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@phoenix.apache.org Delivered-To: mailing list dev@phoenix.apache.org Received: (qmail 4824 invoked by uid 99); 3 May 2019 02:25:01 -0000 Received: from mailrelay1-us-west.apache.org (HELO mailrelay1-us-west.apache.org) (209.188.14.139) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 03 May 2019 02:25:01 +0000 Received: from jira-lw-us.apache.org (unknown [207.244.88.139]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id 4AEC3E29D4 for ; Fri, 3 May 2019 02:25:01 +0000 (UTC) Received: from jira-lw-us.apache.org (localhost [127.0.0.1]) by jira-lw-us.apache.org (ASF Mail Server at jira-lw-us.apache.org) with ESMTP id 9A4AE25813 for ; Fri, 3 May 2019 02:25:00 +0000 (UTC) Date: Fri, 3 May 2019 02:25:00 +0000 (UTC) From: "Thomas D'Silva (JIRA)" To: dev@phoenix.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Updated] (PHOENIX-5023) [UMBRELLA] Clean up giant anonymous inner classes MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/PHOENIX-5023?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Thomas D'Silva updated PHOENIX-5023: ------------------------------------ Summary: [UMBRELLA] Clean up giant anonymous inner classes (was: Clean up giant anonymous inner classes) > [UMBRELLA] Clean up giant anonymous inner classes > ------------------------------------------------- > > Key: PHOENIX-5023 > URL: https://issues.apache.org/jira/browse/PHOENIX-5023 > Project: Phoenix > Issue Type: Improvement > Reporter: Geoffrey Jacoby > Priority: Minor > > A frequent anti-pattern in the Phoenix code base is the use of huge anonymous inner classes, often in the midst of functions that are already very large, or even the parameter list of constructor calls. (The latter means that we have single statements that are technically hundreds of lines long!) > This makes the logic difficult to follow and prevents abstraction. Modern IDEs make changing these to named inner classes quite simple. > This is intended as an umbrella item with subtasks refactoring particular classes, which can be added to over time. -- This message was sent by Atlassian JIRA (v7.6.3#76005)