phoenix-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Thomas D'Silva (JIRA)" <j...@apache.org>
Subject [jira] [Updated] (PHOENIX-5023) [UMBRELLA] Clean up giant anonymous inner classes
Date Fri, 03 May 2019 02:25:00 GMT

     [ https://issues.apache.org/jira/browse/PHOENIX-5023?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Thomas D'Silva updated PHOENIX-5023:
------------------------------------
    Summary: [UMBRELLA] Clean up giant anonymous inner classes  (was: Clean up giant anonymous
inner classes)

> [UMBRELLA] Clean up giant anonymous inner classes
> -------------------------------------------------
>
>                 Key: PHOENIX-5023
>                 URL: https://issues.apache.org/jira/browse/PHOENIX-5023
>             Project: Phoenix
>          Issue Type: Improvement
>            Reporter: Geoffrey Jacoby
>            Priority: Minor
>
> A frequent anti-pattern in the Phoenix code base is the use of huge anonymous inner classes,
often in the midst of functions that are already very large, or even the parameter list of
constructor calls. (The latter means that we have single statements that are technically hundreds
of lines long!)  
> This makes the logic difficult to follow and prevents abstraction. Modern IDEs make changing
these to named inner classes quite simple. 
> This is intended as an umbrella item with subtasks refactoring particular classes, which
can be added to over time. 



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Mime
View raw message