phoenix-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Daniel Wong (JIRA)" <j...@apache.org>
Subject [jira] [Created] (PHOENIX-5244) Leaked "this" reference in ConnectionQueryServicesImpl constructor.
Date Mon, 15 Apr 2019 22:23:00 GMT
Daniel Wong created PHOENIX-5244:
------------------------------------

             Summary: Leaked "this" reference in ConnectionQueryServicesImpl constructor.
                 Key: PHOENIX-5244
                 URL: https://issues.apache.org/jira/browse/PHOENIX-5244
             Project: Phoenix
          Issue Type: Improvement
            Reporter: Daniel Wong


The code [https://github.com/apache/phoenix/blob/master/phoenix-core/src/main/java/org/apache/phoenix/query/ConnectionQueryServicesImpl.java#L427] leaks
"this" to the stats flow in the constructor.  For future stats work it may be possible to
incorrectly access the ConnectionQueryServices for example to warm up the stats cache prior
to any queries being executed and puts us at risk.  A better refactoring would likely decouple
the current connectionQueryServices and the stats so the query portion could be cleanly injected
into the stats as necessary; however, these changes may propagate all the way to the PhoenixDriver
layer.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Mime
View raw message