From dev-return-55267-archive-asf-public=cust-asf.ponee.io@phoenix.apache.org Tue Jan 29 20:23:47 2019 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx-eu-01.ponee.io (Postfix) with SMTP id 70A31180625 for ; Tue, 29 Jan 2019 20:23:47 +0100 (CET) Received: (qmail 32001 invoked by uid 500); 29 Jan 2019 19:23:46 -0000 Mailing-List: contact dev-help@phoenix.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@phoenix.apache.org Delivered-To: mailing list dev@phoenix.apache.org Received: (qmail 31990 invoked by uid 99); 29 Jan 2019 19:23:46 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd4-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 29 Jan 2019 19:23:46 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd4-us-west.apache.org (ASF Mail Server at spamd4-us-west.apache.org) with ESMTP id E0A42C018C for ; Tue, 29 Jan 2019 19:23:45 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd4-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -109.501 X-Spam-Level: X-Spam-Status: No, score=-109.501 tagged_above=-999 required=6.31 tests=[ENV_AND_HDR_SPF_MATCH=-0.5, KAM_ASCII_DIVIDERS=0.8, RCVD_IN_DNSWL_MED=-2.3, SPF_PASS=-0.001, USER_IN_DEF_SPF_WL=-7.5, USER_IN_WHITELIST=-100] autolearn=disabled Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd4-us-west.apache.org [10.40.0.11]) (amavisd-new, port 10024) with ESMTP id Rzo_-lcKgbjf for ; Tue, 29 Jan 2019 19:23:44 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with ESMTP id 0CF905FC6D for ; Tue, 29 Jan 2019 19:15:01 +0000 (UTC) Received: from jira-lw-us.apache.org (unknown [207.244.88.139]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id A0D16E2072 for ; Tue, 29 Jan 2019 19:15:00 +0000 (UTC) Received: from jira-lw-us.apache.org (localhost [127.0.0.1]) by jira-lw-us.apache.org (ASF Mail Server at jira-lw-us.apache.org) with ESMTP id 578F2243B3 for ; Tue, 29 Jan 2019 19:15:00 +0000 (UTC) Date: Tue, 29 Jan 2019 19:15:00 +0000 (UTC) From: "Monani Mihir (JIRA)" To: dev@phoenix.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Updated] (PHOENIX-5080) Index becomes Active during Partial Index Rebuilder if Index Failure happens MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/PHOENIX-5080?page=3Dcom.atlass= ian.jira.plugin.system.issuetabpanels:all-tabpanel ] Monani Mihir updated PHOENIX-5080: ---------------------------------- Attachment: PHOENIX-5080.01.patch > Index becomes Active during Partial Index Rebuilder if Index Failure happ= ens > -------------------------------------------------------------------------= --- > > Key: PHOENIX-5080 > URL: https://issues.apache.org/jira/browse/PHOENIX-5080 > Project: Phoenix > Issue Type: Bug > Affects Versions: 4.14.1 > Reporter: Monani Mihir > Assignee: Monani Mihir > Priority: Blocker > Attachments: PHOENIX-5080-4.x-HBase-1.3.01.patch, PHOENIX-5080-4.= x-HBase-1.3.02.patch, PHOENIX-5080-4.x-HBase-1.3.02.patch, PHOENIX-5080-4.x= -HBase-1.3.03.patch, PHOENIX-5080-4.x-HBase-1.3.04.patch, PHOENIX-5080-4.x-= HBase-1.3.05.patch, PHOENIX-5080.01.patch > > > After PHOENIX-4130=C2=A0and PHOENIX-4600=C2=A0, If there is Index failure= during Partial Index Rebuild, Rebuilder will try again to write Index upda= tes. If it succeeds then it will transition Index from INACTIVE to ACTIVE, = even before Rebuilder finishes. > Here is where it goes wrong, I think :-=C2=A0 > {code:java} > PhoenixIndexFailurePolicy.java :-=20 > public static void doBatchWithRetries(MutateCommand mutateCommand, > =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 IndexWriteException iwe, Phoeni= xConnection connection, ReadOnlyProps config) throws IOException { > .... > while (canRetryMore(numRetry++, maxTries, canRetryUntil)) { > ... > handleIndexWriteSuccessFromClient(iwe, connection); > ... > } > } > .... > private static void handleIndexWriteSuccessFromClient(IndexWriteException= indexWriteException, PhoenixConnection conn) { > =C2=A0 =C2=A0 =C2=A0 =C2=A0 handleExceptionFromClient(indexWriteException= , conn, PIndexState.ACTIVE); > } > {code} > =C2=A0 > =C2=A0 > =C2=A0 -- This message was sent by Atlassian JIRA (v7.6.3#76005)