From dev-return-54759-apmail-phoenix-dev-archive=phoenix.apache.org@phoenix.apache.org Wed Dec 5 01:11:12 2018 Return-Path: X-Original-To: apmail-phoenix-dev-archive@minotaur.apache.org Delivered-To: apmail-phoenix-dev-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 86664180BF for ; Wed, 5 Dec 2018 01:11:12 +0000 (UTC) Received: (qmail 84432 invoked by uid 500); 5 Dec 2018 01:11:12 -0000 Delivered-To: apmail-phoenix-dev-archive@phoenix.apache.org Received: (qmail 84363 invoked by uid 500); 5 Dec 2018 01:11:12 -0000 Mailing-List: contact dev-help@phoenix.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@phoenix.apache.org Delivered-To: mailing list dev@phoenix.apache.org Received: (qmail 84342 invoked by uid 99); 5 Dec 2018 01:11:11 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd4-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 05 Dec 2018 01:11:11 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd4-us-west.apache.org (ASF Mail Server at spamd4-us-west.apache.org) with ESMTP id EE9BBC1D50 for ; Wed, 5 Dec 2018 01:11:10 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd4-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 1.797 X-Spam-Level: * X-Spam-Status: No, score=1.797 tagged_above=-999 required=6.31 tests=[DKIMWL_WL_MED=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, HTML_MESSAGE=2, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=-0.001, SPF_PASS=-0.001] autolearn=disabled Authentication-Results: spamd4-us-west.apache.org (amavisd-new); dkim=pass (1024-bit key) header.d=salesforce.com Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd4-us-west.apache.org [10.40.0.11]) (amavisd-new, port 10024) with ESMTP id PUUw1gXlWWoW for ; Wed, 5 Dec 2018 01:11:08 +0000 (UTC) Received: from mail-lj1-f194.google.com (mail-lj1-f194.google.com [209.85.208.194]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with ESMTPS id 4C8065FB3E for ; Wed, 5 Dec 2018 01:11:08 +0000 (UTC) Received: by mail-lj1-f194.google.com with SMTP id x85-v6so16743439ljb.2 for ; Tue, 04 Dec 2018 17:11:08 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=salesforce.com; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to; bh=0lPbFrsGqKpQ42CGdwwP9313L5j1Bg5EBsS1M+OhMtI=; b=SY++qWCK+bpTBIpEIOl+XyGISyFYLnFAAchA3ernq544HdvHRCqi5t8R5QrXd/ffE0 UQ8Ohu2LqqLFi/qHmsbzubvYpf5T+030mIAUJWObGkACsveg/7AOB9/hDJdzaTTraPOk La0E+GNeXyPnSmfJ3uKrogFxM268UmrcsvEPs= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to; bh=0lPbFrsGqKpQ42CGdwwP9313L5j1Bg5EBsS1M+OhMtI=; b=FhAqfuOqgvGpRjTOEllb1x6SlpJoVgjDO4/xiAUSXKKvhxZ/8nQ0WqK45ujzmeYNxK nWs8OprkGtmtsK9iMw5bqwz1OhG556E3P9kCjKC8hRrpJptLv3QEXTVLr8zMX5oC6JQG oFdmC41ckiljLliXvc11qeQDp64uPQ5P4yFqKOQeN9vX8MD8rk6DZKMbtdjmIzcFUYwJ kxyohpMxqsBI7/rg/h8RcHf2ttngwk421PSKUezFPB6X3nPYl0DqfwU+PjI+Azw6DcC9 8mvht7hxVQJ/5XZ0oDu7S9Z/8xC5A10M2YFjqf9KK8u+sEdwJMSrBcBJLL7dpSP5DDf4 NGvg== X-Gm-Message-State: AA+aEWbc7hOsCa5MEVrMf23sGYLTh5Gvh31vnDju3cGv8AFUNIvOKeLa /ORxhprn7aIgJsWDC7Qpj31CD6ntUmJaLQcEa45moKHo X-Google-Smtp-Source: AFSGD/UkO6QYTBOEZls+o19wVrnQ0s2xgLwdB9ROJN2eoS7cKeRHiKp+tz6MdtWWsUoApShvnn15zpJ4iAaOL7m7msc= X-Received: by 2002:a2e:88cf:: with SMTP id a15-v6mr13924718ljk.76.1543972261384; Tue, 04 Dec 2018 17:11:01 -0800 (PST) MIME-Version: 1.0 References: In-Reply-To: From: "Thomas D'Silva" Date: Tue, 4 Dec 2018 17:10:49 -0800 Message-ID: Subject: Re: [DISCUSS] Drop support for java 1.7 on the 1.2, 1.3 and 1.4 branches To: dev@phoenix.apache.org Content-Type: multipart/alternative; boundary="0000000000002f12e7057c3c0e82" --0000000000002f12e7057c3c0e82 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Should we have one repo for the connectors (phoenix-flume, phoenix-hive, phoenix-kafka, phoenix-pig and phoenix-spark) and a separate repo for the queryserver? On Tue, Dec 4, 2018 at 3:58 PM Vincent Poon wrote: > +1 to another repo for connectors > > On Mon, Dec 3, 2018 at 6:27 PM James Taylor > wrote: > > > +1. Good idea, Thomas. > > > > On Mon, Dec 3, 2018 at 2:57 PM Thomas D'Silva > > wrote: > > > > > I believe we will be maintaining the 4.x branches which support HBase > > 1.2, > > > 1.3 and 1.4 for a while. > > > Should we think about pulling out the connectors and queryserver into > > their > > > own repo similar to > > > what HBase did (see https://issues.apache.org/jira/browse/HBASE-20934 > ). > > > They could then have > > > their own release schedule and Java support. > > > > > > > > > On Sat, Dec 1, 2018 at 6:53 AM Pedro Boado > > wrote: > > > > > > > Well I don't count with a lot more 4.x releases - maybe I'm > > wrong-headed > > > . > > > > For master branch and cdh6 we'd be looking at spark 2.x > > > > > > > > Part of the success of a project is about version stability. Not a > lot > > of > > > > corporate projects can afford keep upgrading to the latest versions= - > > > think > > > > about it, you're in production, with a few thousand lines code > running > > > > spark 1.6 ... And for upgrading to 4.14 you need to review all of > this > > > > spark code -and maybe recompile to scala 2.11 btw- . It doesn't mak= e > > > sense. > > > > Until now 4.x was pretty stable and in my opinion it should've neve= r > > been > > > > migrated to spark 2 and java 8. Minor versions should keep certain > > > > stability in terms of dependencies. > > > > > > > > All these changes should've come with phoenix 5. But you're right i= t > > > needs > > > > a sensible solution as 4.14.1 is already out and compiled with java= 8. > > > > > > > > > > > > > > > > On Fri, 30 Nov 2018, 23:28 Thomas D'Silva > wrote: > > > > > > > > > Spark 1.6 is really old and doesn't support the newer Datasource = v2 > > api > > > > > that we have been looking at integrating with. > > > > > As Alex points out you will might end up having to revert a lot > more > > > > > commits in the future. > > > > > Seems like the queryserver and phoenix-spark modules on the cdh > > branch > > > > > would end up diverging a lot from the standard open source branch= . > > > > > > > > > > > > > > > On Fri, Nov 30, 2018 at 2:23 PM Alex Araujo > > > > wrote: > > > > > > > > > > > > Only a downgrade to spark 1.6 ( > > > > > > changes are only needed in a few IT, basically going back from > > > Datasets > > > > > to > > > > > > Dataframes) and going back to Avatica 1.10 ( involving reverti= ng > > > > > > PHOENIX-4755, PHOENIX-4750 and PHOENIX-4805 ). > > > > > > > > > > > > We're talking about the 4.x branches, right? Doesn't seem prude= nt > > to > > > do > > > > > it > > > > > > there as down-streamers may already be relying on the newer > > versions. > > > > > > > > > > > > On Fri, Nov 30, 2018 at 4:18 PM Pedro Boado < > pedro.boado@gmail.com > > > > > > > > wrote: > > > > > > > > > > > > > Thinking about typical server installation in a corporate > > > environment > > > > > I'd > > > > > > > keep everything compatible with the same JVM version. > > > > > > > > > > > > > > I've gone down the route for the cdh branch. Full JDK 7 > > > compatibility > > > > > > > doesn't require changes in phoenix-core. Only a downgrade to > > spark > > > > 1.6 > > > > > ( > > > > > > > changes are only needed in a few IT, basically going back fro= m > > > > Datasets > > > > > > to > > > > > > > Dataframes) and going back to Avatica 1.10 ( involving > reverting > > > > > > > PHOENIX-4755, PHOENIX-4750 and PHOENIX-4805 ). > > > > > > > > > > > > > > > > > > > > > On Fri, 30 Nov 2018, 18:57 Thomas D'Silva < > tsilva@salesforce.com > > > > > > > wrote: > > > > > > > > > > > > > > > We could allow individual submodules like the queryserver, = or > > > > > > > phoenix-spark > > > > > > > > to be built with their own compiler configuration (1.8+). > > > > > > > > This would allow these modules to use Java 1.8 features. I > > think > > > > this > > > > > > > would > > > > > > > > be a good compromise given that they depend on > > > > > > > > features that are provided by versions of spark and avatica > > that > > > no > > > > > > > longer > > > > > > > > support Java 1.7. > > > > > > > > We can still ensure phoenix-core supports Java 1.7. You wou= ld > > > have > > > > to > > > > > > > skip > > > > > > > > building modules that require Java 1.8, WDYT? > > > > > > > > > > > > > > > > On Thu, Nov 29, 2018 at 6:11 PM Jaanai Zhang < > > > > cloud.poster@gmail.com > > > > > > > > > > > > > > wrote: > > > > > > > > > > > > > > > > > I'd vote for keep using java7 on 4.x branches. if upgrade= s > to > > > > > java8, > > > > > > it > > > > > > > > > will impact users who want to upgrade the latest 4.x > > branches. > > > > they > > > > > > > must > > > > > > > > > consider using java8 in their running environments, mayb= e > > > their > > > > > > > > libraries > > > > > > > > > do not support java8, then they have to give up to upgrad= e. > > So > > > I > > > > > > think > > > > > > > > that > > > > > > > > > drops support java7 is not friendly for some users. > > > > > > > > > > > > > > > > > > > > > > > > > > > ---------------------------------------- > > > > > > > > > Jaanai Zhang > > > > > > > > > Best regards! > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > Pedro Boado =E4=BA=8E2018=E5=B9= =B411=E6=9C=8830=E6=97=A5=E5=91=A8=E4=BA=94 > =E4=B8=8A=E5=8D=886:13=E5=86=99=E9=81=93=EF=BC=9A > > > > > > > > > > > > > > > > > > > I'd vote for keep compiling 4.x branches in java7. It > makes > > > > sense > > > > > > as > > > > > > > > it's > > > > > > > > > > just a new minor release. > > > > > > > > > > > > > > > > > > > > It's pretty easy reverting back to spark 1.6 and also > > avatica > > > > > > > > dependency > > > > > > > > > > could be reverted to the previous version. > > > > > > > > > > > > > > > > > > > > On 29 Nov 2018 21:41, "Thomas D'Silva" < > > > tdsilva@salesforce.com > > > > > > > > > > > > wrote: > > > > > > > > > > > > > > > > > > > > We have traditionally followed HBase's java support (se= e > > > > > > > > > > https://hbase.apache.org/book.html#basic.prerequisites)= . > > The > > > > > > > > > > phoenix-queryserver module has a dependency on Avatica > > which > > > > does > > > > > > not > > > > > > > > > > support Java 1.7. The phoenix-spark module depends on > spark > > > > 2.3.2 > > > > > > > which > > > > > > > > > > also does not support Java 1.7. Do folks feel we should > > > > continue > > > > > to > > > > > > > > > provide > > > > > > > > > > support Java 1.7 on the 1.x branches? > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > On Fri, 30 Nov 2018, 18:57 Thomas D'Silva < > > tdsilva@salesforce.com > > > > > wrote: > > > > > > > > > > > > > > > We could allow individual submodules like the queryserver, = or > > > > > > > phoenix-spark > > > > > > > > to be built with their own compiler configuration (1.8+). > > > > > > > > This would allow these modules to use Java 1.8 features. I > > think > > > > this > > > > > > > would > > > > > > > > be a good compromise given that they depend on > > > > > > > > features that are provided by versions of spark and avatica > > that > > > no > > > > > > > longer > > > > > > > > support Java 1.7. > > > > > > > > We can still ensure phoenix-core supports Java 1.7. You wou= ld > > > have > > > > to > > > > > > > skip > > > > > > > > building modules that require Java 1.8, WDYT? > > > > > > > > > > > > > > > > On Thu, Nov 29, 2018 at 6:11 PM Jaanai Zhang < > > > > cloud.poster@gmail.com > > > > > > > > > > > > > > wrote: > > > > > > > > > > > > > > > > > I'd vote for keep using java7 on 4.x branches. if upgrade= s > to > > > > > java8, > > > > > > it > > > > > > > > > will impact users who want to upgrade the latest 4.x > > branches. > > > > they > > > > > > > must > > > > > > > > > consider using java8 in their running environments, mayb= e > > > their > > > > > > > > libraries > > > > > > > > > do not support java8, then they have to give up to upgrad= e. > > So > > > I > > > > > > think > > > > > > > > that > > > > > > > > > drops support java7 is not friendly for some users. > > > > > > > > > > > > > > > > > > > > > > > > > > > ---------------------------------------- > > > > > > > > > Jaanai Zhang > > > > > > > > > Best regards! > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > Pedro Boado =E4=BA=8E2018=E5=B9= =B411=E6=9C=8830=E6=97=A5=E5=91=A8=E4=BA=94 > =E4=B8=8A=E5=8D=886:13=E5=86=99=E9=81=93=EF=BC=9A > > > > > > > > > > > > > > > > > > > I'd vote for keep compiling 4.x branches in java7. It > makes > > > > sense > > > > > > as > > > > > > > > it's > > > > > > > > > > just a new minor release. > > > > > > > > > > > > > > > > > > > > It's pretty easy reverting back to spark 1.6 and also > > avatica > > > > > > > > dependency > > > > > > > > > > could be reverted to the previous version. > > > > > > > > > > > > > > > > > > > > On 29 Nov 2018 21:41, "Thomas D'Silva" < > > > tdsilva@salesforce.com > > > > > > > > > > > > wrote: > > > > > > > > > > > > > > > > > > > > We have traditionally followed HBase's java support (se= e > > > > > > > > > > https://hbase.apache.org/book.html#basic.prerequisites)= . > > The > > > > > > > > > > phoenix-queryserver module has a dependency on Avatica > > which > > > > does > > > > > > not > > > > > > > > > > support Java 1.7. The phoenix-spark module depends on > spark > > > > 2.3.2 > > > > > > > which > > > > > > > > > > also does not support Java 1.7. Do folks feel we should > > > > continue > > > > > to > > > > > > > > > provide > > > > > > > > > > support Java 1.7 on the 1.x branches? > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > --0000000000002f12e7057c3c0e82--