From dev-return-53529-archive-asf-public=cust-asf.ponee.io@phoenix.apache.org Thu Aug 2 00:42:45 2018 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx-eu-01.ponee.io (Postfix) with SMTP id 1797B180634 for ; Thu, 2 Aug 2018 00:42:44 +0200 (CEST) Received: (qmail 4942 invoked by uid 500); 1 Aug 2018 22:42:44 -0000 Mailing-List: contact dev-help@phoenix.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@phoenix.apache.org Delivered-To: mailing list dev@phoenix.apache.org Received: (qmail 4925 invoked by uid 99); 1 Aug 2018 22:42:43 -0000 Received: from git1-us-west.apache.org (HELO git1-us-west.apache.org) (140.211.11.23) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 01 Aug 2018 22:42:43 +0000 Received: by git1-us-west.apache.org (ASF Mail Server at git1-us-west.apache.org, from userid 33) id 6EC6DDFB34; Wed, 1 Aug 2018 22:42:43 +0000 (UTC) From: karanmehta93 To: dev@phoenix.apache.org Reply-To: dev@phoenix.apache.org References: In-Reply-To: Subject: [GitHub] phoenix pull request #315: PHOENIX-3655 Global Phoenix Client Metrics for PQ... Content-Type: text/plain Message-Id: <20180801224243.6EC6DDFB34@git1-us-west.apache.org> Date: Wed, 1 Aug 2018 22:42:43 +0000 (UTC) Github user karanmehta93 commented on a diff in the pull request: https://github.com/apache/phoenix/pull/315#discussion_r207054877 --- Diff: phoenix-core/src/test/resources/hadoop-metrics2.properties --- @@ -32,10 +32,9 @@ # [prefix].[source|sink].[instance].[options] # See javadoc of package-info.java for org.apache.hadoop.metrics2 for detail - -# Don't attempt to start jmx mbeans for all sources. -# For right now, all metrics are exported to a phoenix table -*.source.start_mbeans=false +phoenix.source.start_mbeans=true +phoenix.sink.sink0.class=org.apache.phoenix.monitoring.GlobalPhoenixMetricsTestSink --- End diff -- It is just an identifier and can be anything. ---